netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: jhs@mojatatu.com, Cong Wang <xiyou.wangcong@gmail.com>,
	Roman Mashak <mrv@mojatatu.com>
Subject: [Patch net v4 7/7] net_sched: allow flushing tc police actions
Date: Sat, 13 Aug 2016 22:35:02 -0700	[thread overview]
Message-ID: <1471152902-12444-8-git-send-email-xiyou.wangcong@gmail.com> (raw)
In-Reply-To: <1471152902-12444-1-git-send-email-xiyou.wangcong@gmail.com>

From: Roman Mashak <mrv@mojatatu.com>

The act_police uses its own code to walk the
action hashtable, which leads to that we could
not flush standalone tc police actions, so just
switch to tcf_generic_walker() like other actions.

(Joint work from Roman and Cong.)

Signed-off-by: Roman Mashak <mrv@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
 net/sched/act_police.c | 43 +------------------------------------------
 1 file changed, 1 insertion(+), 42 deletions(-)

diff --git a/net/sched/act_police.c b/net/sched/act_police.c
index 259352d..8a3be1d 100644
--- a/net/sched/act_police.c
+++ b/net/sched/act_police.c
@@ -63,49 +63,8 @@ static int tcf_act_police_walker(struct net *net, struct sk_buff *skb,
 				 const struct tc_action_ops *ops)
 {
 	struct tc_action_net *tn = net_generic(net, police_net_id);
-	struct tcf_hashinfo *hinfo = tn->hinfo;
-	int err = 0, index = -1, i = 0, s_i = 0, n_i = 0;
-	struct nlattr *nest;
-
-	spin_lock_bh(&hinfo->lock);
-
-	s_i = cb->args[0];
-
-	for (i = 0; i < (POL_TAB_MASK + 1); i++) {
-		struct hlist_head *head;
-		struct tc_action *p;
-
-		head = &hinfo->htab[tcf_hash(i, POL_TAB_MASK)];
-
-		hlist_for_each_entry_rcu(p, head, tcfa_head) {
-			index++;
-			if (index < s_i)
-				continue;
-			nest = nla_nest_start(skb, index);
-			if (nest == NULL)
-				goto nla_put_failure;
-			if (type == RTM_DELACTION)
-				err = tcf_action_dump_1(skb, p, 0, 1);
-			else
-				err = tcf_action_dump_1(skb, p, 0, 0);
-			if (err < 0) {
-				index--;
-				nla_nest_cancel(skb, nest);
-				goto done;
-			}
-			nla_nest_end(skb, nest);
-			n_i++;
-		}
-	}
-done:
-	spin_unlock_bh(&hinfo->lock);
-	if (n_i)
-		cb->args[0] += n_i;
-	return n_i;
 
-nla_put_failure:
-	nla_nest_cancel(skb, nest);
-	goto done;
+	return tcf_generic_walker(tn, skb, cb, type, ops);
 }
 
 static const struct nla_policy police_policy[TCA_POLICE_MAX + 1] = {
-- 
1.8.4.5

  parent reply	other threads:[~2016-08-14  9:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-14  5:34 [Patch net v4 0/7] net_sched: tc action fixes and updates Cong Wang
2016-08-14  5:34 ` [Patch net v4 1/7] net_sched: remove the leftover cleanup_a() Cong Wang
2016-08-14 11:01   ` Jamal Hadi Salim
2016-08-14  5:34 ` [Patch net v4 2/7] net_sched: remove an unnecessary list_del() Cong Wang
2016-08-14 11:01   ` Jamal Hadi Salim
2016-08-14  5:34 ` [Patch net v4 3/7] net_sched: fix a typo in tc_for_each_action() Cong Wang
2016-08-14 11:02   ` Jamal Hadi Salim
2016-08-14  5:34 ` [Patch net v4 4/7] net_sched: move tc offload macros to pkt_cls.h Cong Wang
2016-08-14 11:03   ` Jamal Hadi Salim
2016-08-14  5:35 ` [Patch net v4 5/7] net_sched: convert tcf_exts from list to pointer array Cong Wang
2016-08-14 11:04   ` Jamal Hadi Salim
2016-08-14  5:35 ` [Patch net v4 6/7] net_sched: unify the init logic for act_police Cong Wang
2016-08-14 11:04   ` Jamal Hadi Salim
2016-08-14  5:35 ` Cong Wang [this message]
2016-08-14 11:05   ` [Patch net v4 7/7] net_sched: allow flushing tc police actions Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471152902-12444-8-git-send-email-xiyou.wangcong@gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=mrv@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).