From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com,
yotamg@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com
Subject: [patch net 9/9] mlxsw: reg: Fix missing op field fill-up
Date: Mon, 15 Aug 2016 16:37:53 +0200 [thread overview]
Message-ID: <1471271873-4389-10-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1471271873-4389-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@mellanox.com>
Ralue pack function needs to set op, otherwise it is 0 for add always.
Fixes: d5a1c749d22 ("mlxsw: reg: Add Router Algorithmic LPM Unicast Entry Register definition")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
drivers/net/ethernet/mellanox/mlxsw/reg.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/net/ethernet/mellanox/mlxsw/reg.h
index 7ca9201..14a5731 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/reg.h
+++ b/drivers/net/ethernet/mellanox/mlxsw/reg.h
@@ -4000,6 +4000,7 @@ static inline void mlxsw_reg_ralue_pack(char *payload,
{
MLXSW_REG_ZERO(ralue, payload);
mlxsw_reg_ralue_protocol_set(payload, protocol);
+ mlxsw_reg_ralue_op_set(payload, op);
mlxsw_reg_ralue_virtual_router_set(payload, virtual_router);
mlxsw_reg_ralue_prefix_len_set(payload, prefix_len);
mlxsw_reg_ralue_entry_type_set(payload,
--
2.5.5
prev parent reply other threads:[~2016-08-15 14:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 14:37 [patch net 0/9] mlxsw: couple of fixes Jiri Pirko
2016-08-15 14:37 ` [patch net 1/9] mlxsw: spectrum: Don't return upon error in removal path Jiri Pirko
2016-08-15 14:37 ` [patch net 2/9] mlxsw: spectrum: Remove redundant errors from the code Jiri Pirko
2016-08-15 14:37 ` [patch net 3/9] mlxsw: spectrum: Create PVID vPort before registering netdevice Jiri Pirko
2016-08-15 14:37 ` [patch net 4/9] mlxsw: spectrum: Mark port as active before registering it Jiri Pirko
2016-08-15 14:37 ` [patch net 5/9] mlxsw: spectrum: Add missing packet traps Jiri Pirko
2016-08-15 14:51 ` Ilan Tayari
2016-08-15 19:56 ` Ido Schimmel
2016-08-15 14:37 ` [patch net 6/9] mlxsw: spectrum: Add missing rollbacks in error path Jiri Pirko
2016-08-15 14:37 ` [patch net 7/9] mlxsw: spectrum: Unmap 802.1Q FID before destroying it Jiri Pirko
2016-08-15 14:37 ` [patch net 8/9] mlxsw: spectrum: Allow packets to be trapped from any PG Jiri Pirko
2016-08-15 14:37 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471271873-4389-10-git-send-email-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).