* [PATCH -next] net: ena: Fix error return code in ena_device_init()
@ 2016-08-15 22:51 Wei Yongjun
2016-08-15 23:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-15 22:51 UTC (permalink / raw)
To: Netanel Belgazal, Saeed Bishara, Zorik Machulsky, David S. Miller
Cc: Wei Yongjun, netdev
Fix to return a negative error code from the invalid dma width
error handling case instead of 0.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 94790df..4cbe014 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -2329,6 +2329,7 @@ static int ena_device_init(struct ena_com_dev *ena_dev, struct pci_dev *pdev,
dma_width = ena_com_get_dma_width(ena_dev);
if (dma_width < 0) {
dev_err(dev, "Invalid dma width value %d", dma_width);
+ rc = dma_width;
goto err_mmio_read_less;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: ena: Fix error return code in ena_device_init()
2016-08-15 22:51 [PATCH -next] net: ena: Fix error return code in ena_device_init() Wei Yongjun
@ 2016-08-15 23:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-08-15 23:34 UTC (permalink / raw)
To: weiyj.lk; +Cc: netanel, saeed, zorik, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Mon, 15 Aug 2016 22:51:04 +0000
> Fix to return a negative error code from the invalid dma width
> error handling case instead of 0.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-15 23:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-15 22:51 [PATCH -next] net: ena: Fix error return code in ena_device_init() Wei Yongjun
2016-08-15 23:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).