From: Daniel Wagner <wagi@monom.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Christian Lamparter <chunkeey@googlemail.com>
Subject: [PATCH 0/2] wireless: Use complete() instead complete_all()
Date: Thu, 18 Aug 2016 15:12:04 +0200 [thread overview]
Message-ID: <1471525926-20384-1-git-send-email-wagi@monom.org> (raw)
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Hi,
Using complete_all() is not wrong per se but it suggest that there
might be more than one reader. For -rt I am reviewing all
complete_all() users and would like to leave only the real ones in the
tree. The main problem for -rt about complete_all() is that it can be
uses inside IRQ context and that can lead to unbounded amount work
inside the interrupt handler. That is a no no for -rt.
The patches grouped per subsystem and in small batches to allow
reviewing.
This series ignores all complete_all() usages in the firmware loading
path. They will be hopefully address by Luis' sysdata patches [0].
That leaves a couple of complete_all() calls.
The first patch fixes a real glitch for the carl9170 driver. I was
able to test it because I have the hardware. For the second one I
haven't found any dongle with that chip in my drawers.
This series against net-next of today.
cheers,
daniel
[0] https://lkml.kernel.org/r/1466117661-22075-1-git-send-email-mcgrof@kernel.org
Daniel Wagner (2):
carl9170: Fix wrong completion usage
ath10k: use complete() instead complete_all()
drivers/net/wireless/ath/ath10k/core.c | 16 ++++++++--------
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
drivers/net/wireless/ath/carl9170/usb.c | 6 ++----
3 files changed, 11 insertions(+), 13 deletions(-)
--
2.7.4
next reply other threads:[~2016-08-18 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 13:12 Daniel Wagner [this message]
2016-08-18 13:12 ` [PATCH 1/2] carl9170: Fix wrong completion usage Daniel Wagner
2016-09-09 12:16 ` [1/2] " Kalle Valo
2016-08-18 13:12 ` [PATCH 2/2] ath10k: use complete() instead complete_all() Daniel Wagner
2016-09-02 15:55 ` [2/2] " Kalle Valo
2016-08-18 19:16 ` [PATCH 0/2] wireless: Use " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471525926-20384-1-git-send-email-wagi@monom.org \
--to=wagi@monom.org \
--cc=ath10k@lists.infradead.org \
--cc=chunkeey@googlemail.com \
--cc=daniel.wagner@bmw-carit.de \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).