From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH net-next 0/3] Fix mv88e6xxx wait function
Date: Fri, 19 Aug 2016 00:01:54 +0200 [thread overview]
Message-ID: <1471557717-21852-1-git-send-email-andrew@lunn.ch> (raw)
The mv88e6xxx wait function can be upset of the system has nots of
other things to do and a sleep takes a lot longer than expected. Fix
this be using a fixed number of iterations, rather than a fixed
walkclock time.
Witht that change made, it is possible to consoliate another
wait function.
A wait actually timing out should not happen and when it does, it
means something serious is wrong. Make sure an error is logged,
since not all callers will log an error.
Andrew Lunn (3):
dsa: mv88e6xxx: Timeout based on iterations, not time
dsa: mv88e6xxx: Use mv88e6xx_wait in mv88e6xxx_update()
dsa: mv88e6xxx: Make mv88e6xxx_wait() timeout verbose
drivers/net/dsa/mv88e6xxx/chip.c | 32 +++++++++++---------------------
1 file changed, 11 insertions(+), 21 deletions(-)
--
2.8.1
next reply other threads:[~2016-08-19 1:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 22:01 Andrew Lunn [this message]
2016-08-18 22:01 ` [PATCH net-next 1/3] dsa: mv88e6xxx: Timeout based on iterations, not time Andrew Lunn
2016-08-18 22:01 ` [PATCH net-next 2/3] dsa: mv88e6xxx: Use mv88e6xx_wait in mv88e6xxx_update() Andrew Lunn
2016-08-18 22:01 ` [PATCH net-next 3/3] dsa: mv88e6xxx: Make mv88e6xxx_wait() timeout verbose Andrew Lunn
2016-08-18 22:22 ` [PATCH net-next 0/3] Fix mv88e6xxx wait function Vivien Didelot
2016-08-20 0:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471557717-21852-1-git-send-email-andrew@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).