* [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning
@ 2016-08-23 15:06 Wei Yongjun
2016-08-23 15:16 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wei Yongjun @ 2016-08-23 15:06 UTC (permalink / raw)
To: f.fainelli, michal.simek, soren.brinkmann
Cc: netdev, Wei Yongjun, linux-arm-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index e7a20ec..2e408b8 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
return 0;
}
-int xgmiitorgmii_probe(struct mdio_device *mdiodev)
+static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
{
struct device *dev = &mdiodev->dev;
struct device_node *np = dev->of_node, *phy_node;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning
2016-08-23 15:06 [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning Wei Yongjun
@ 2016-08-23 15:16 ` Andrew Lunn
2016-08-23 15:41 ` Wei Yongjun
2016-08-23 16:40 ` Kedari Appana
2016-08-24 0:18 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2016-08-23 15:16 UTC (permalink / raw)
To: Wei Yongjun
Cc: f.fainelli, netdev, michal.simek, Wei Yongjun, soren.brinkmann,
linux-arm-kernel
On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
Hi Wei
No need for the additional From:
git am will use the one in the mail header as the author of the patch,
and it is in the signed-off-by as well.
Thanks
Andrew
> Fixes the following sparse warning:
>
> drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
> symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index e7a20ec..2e408b8 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
> return 0;
> }
>
> -int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> +static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> {
> struct device *dev = &mdiodev->dev;
> struct device_node *np = dev->of_node, *phy_node;
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning
2016-08-23 15:16 ` Andrew Lunn
@ 2016-08-23 15:41 ` Wei Yongjun
2016-08-23 15:50 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Wei Yongjun @ 2016-08-23 15:41 UTC (permalink / raw)
To: Andrew Lunn
Cc: f.fainelli, michal.simek, soren.brinkmann, netdev, Wei Yongjun,
linux-arm-kernel
Hi Andrew,
On 08/23/2016 11:16 PM, Andrew Lunn wrote:
> On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
>> From: Wei Yongjun <weiyongjun1@huawei.com>
> Hi Wei
>
> No need for the additional From:
>
> git am will use the one in the mail header as the author of the patch,
> and it is in the signed-off-by as well.
The mail address which I sent the patch is different with the
signed-of-by one, so git send-email will not remove the From line.
Regards,
Yongjun Wei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning
2016-08-23 15:41 ` Wei Yongjun
@ 2016-08-23 15:50 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2016-08-23 15:50 UTC (permalink / raw)
To: Wei Yongjun
Cc: f.fainelli, netdev, michal.simek, Wei Yongjun, soren.brinkmann,
linux-arm-kernel
On Tue, Aug 23, 2016 at 11:41:25PM +0800, Wei Yongjun wrote:
> Hi Andrew,
>
> On 08/23/2016 11:16 PM, Andrew Lunn wrote:
> > On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
> >> From: Wei Yongjun <weiyongjun1@huawei.com>
> > Hi Wei
> >
> > No need for the additional From:
> >
> > git am will use the one in the mail header as the author of the patch,
> > and it is in the signed-off-by as well.
>
> The mail address which I sent the patch is different with the
> signed-of-by one, so git send-email will not remove the From line.
Cool. git am strips it out of the commit message and uses it as the
Author. I didn't know it did that.
Sorry for the noise,
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning
2016-08-23 15:06 [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning Wei Yongjun
2016-08-23 15:16 ` Andrew Lunn
@ 2016-08-23 16:40 ` Kedari Appana
2016-08-24 0:18 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: Kedari Appana @ 2016-08-23 16:40 UTC (permalink / raw)
To: Wei Yongjun
Cc: Florian Fainelli, netdev, michal.simek, Wei Yongjun,
soren.brinkmann, linux-arm-kernel
HI,
Thanks for the patch..
On Tue, Aug 23, 2016 at 8:36 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
> symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked by: Kedareswara rao Appana <appanad@xilinx.com>
> ---
> drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index e7a20ec..2e408b8 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
> return 0;
> }
>
> -int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> +static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> {
> struct device *dev = &mdiodev->dev;
> struct device_node *np = dev->of_node, *phy_node;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning
2016-08-23 15:06 [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning Wei Yongjun
2016-08-23 15:16 ` Andrew Lunn
2016-08-23 16:40 ` Kedari Appana
@ 2016-08-24 0:18 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-08-24 0:18 UTC (permalink / raw)
To: weiyj.lk
Cc: f.fainelli, michal.simek, soren.brinkmann, weiyongjun1, netdev,
linux-arm-kernel
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Tue, 23 Aug 2016 15:06:05 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
> symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-24 0:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-23 15:06 [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning Wei Yongjun
2016-08-23 15:16 ` Andrew Lunn
2016-08-23 15:41 ` Wei Yongjun
2016-08-23 15:50 ` Andrew Lunn
2016-08-23 16:40 ` Kedari Appana
2016-08-24 0:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).