* [PATCH -next] vmxnet3: fix non static symbol warning
@ 2016-08-23 15:05 Wei Yongjun
2016-08-23 17:13 ` Shrikrishna Khare
2016-08-24 15:07 ` [PATCH v2] " Wei Yongjun
0 siblings, 2 replies; 5+ messages in thread
From: Wei Yongjun @ 2016-08-23 15:05 UTC (permalink / raw)
To: Shrikrishna Khare, VMware, Inc.; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning:
symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 4244b9d..2fd93b4 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1641,7 +1641,7 @@ static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,
}
}
-void
+static void
vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter)
{
int i;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] vmxnet3: fix non static symbol warning
2016-08-23 15:05 [PATCH -next] vmxnet3: fix non static symbol warning Wei Yongjun
@ 2016-08-23 17:13 ` Shrikrishna Khare
2016-08-24 15:07 ` [PATCH v2] " Wei Yongjun
1 sibling, 0 replies; 5+ messages in thread
From: Shrikrishna Khare @ 2016-08-23 17:13 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Shrikrishna Khare, VMware, Inc., Wei Yongjun, netdev
On Tue, 23 Aug 2016, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning:
> symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks for catching and fixing this. The fix looks good. But, could you
please send this against net tree instead of net-next?
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 4244b9d..2fd93b4 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1641,7 +1641,7 @@ static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,
> }
> }
>
> -void
> +static void
> vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter)
> {
> int i;
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] vmxnet3: fix non static symbol warning
2016-08-23 15:05 [PATCH -next] vmxnet3: fix non static symbol warning Wei Yongjun
2016-08-23 17:13 ` Shrikrishna Khare
@ 2016-08-24 15:07 ` Wei Yongjun
2016-08-24 15:22 ` Shrikrishna Khare
2016-08-25 23:43 ` David Miller
1 sibling, 2 replies; 5+ messages in thread
From: Wei Yongjun @ 2016-08-24 15:07 UTC (permalink / raw)
To: Shrikrishna Khare, VMware, Inc.; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning:
symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: rebase on netdev tree
---
drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 4244b9d..2fd93b4 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1641,7 +1641,7 @@ static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,
}
}
-void
+static void
vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter)
{
int i;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] vmxnet3: fix non static symbol warning
2016-08-24 15:07 ` [PATCH v2] " Wei Yongjun
@ 2016-08-24 15:22 ` Shrikrishna Khare
2016-08-25 23:43 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Shrikrishna Khare @ 2016-08-24 15:22 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Shrikrishna Khare, VMware, Inc., Wei Yongjun, netdev
On Wed, 24 Aug 2016, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning:
> symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
> ---
> v1 -> v2: rebase on netdev tree
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 4244b9d..2fd93b4 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1641,7 +1641,7 @@ static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,
> }
> }
>
> -void
> +static void
> vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter)
> {
> int i;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] vmxnet3: fix non static symbol warning
2016-08-24 15:07 ` [PATCH v2] " Wei Yongjun
2016-08-24 15:22 ` Shrikrishna Khare
@ 2016-08-25 23:43 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2016-08-25 23:43 UTC (permalink / raw)
To: weiyj.lk; +Cc: skhare, pv-drivers, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Wed, 24 Aug 2016 15:07:26 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning:
> symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-25 23:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-23 15:05 [PATCH -next] vmxnet3: fix non static symbol warning Wei Yongjun
2016-08-23 17:13 ` Shrikrishna Khare
2016-08-24 15:07 ` [PATCH v2] " Wei Yongjun
2016-08-24 15:22 ` Shrikrishna Khare
2016-08-25 23:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).