From: David Ahern <dsa@cumulusnetworks.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: buytenh@wantstofly.org, simon.horman@netronome.com,
ebiederm@xmission.com, rshearma@brocade.com, tom@herbertland.com,
tgraf@suug.ch, olivier.dugeon@orange.com,
alexander.duyck@gmail.com, roopa@cumulusnetworks.com,
David Ahern <dsa@cumulusnetworks.com>
Subject: [PATCH net-next v4 3/3] net: veth: Set features for MPLS
Date: Wed, 24 Aug 2016 20:10:45 -0700 [thread overview]
Message-ID: <1472094645-11452-4-git-send-email-dsa@cumulusnetworks.com> (raw)
In-Reply-To: <1472094645-11452-1-git-send-email-dsa@cumulusnetworks.com>
veth does not really transmit packets only moves the skb from one
netdev to another so gso and checksum is not really needed. Add
the features to mpls_features to get the same benefit and performance
with MPLS as without it.
Reported-by: Lennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
drivers/net/veth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index f37a6e61d4ad..5db320a4d5cf 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -340,6 +340,7 @@ static void veth_setup(struct net_device *dev)
dev->hw_features = VETH_FEATURES;
dev->hw_enc_features = VETH_FEATURES;
+ dev->mpls_features = NETIF_F_HW_CSUM | NETIF_F_GSO_SOFTWARE;
}
/*
--
2.1.4
next prev parent reply other threads:[~2016-08-25 4:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 3:10 [PATCH net-next v4 0/3] net: mpls: fragmentation and gso fixes for locally originated traffic David Ahern
2016-08-25 3:10 ` [PATCH net-next v4 1/3] net: lwtunnel: Handle fragmentation David Ahern
2016-08-25 3:10 ` [PATCH net-next v4 2/3] net: mpls: Fixups for GSO David Ahern
2016-08-25 3:10 ` David Ahern [this message]
2016-08-26 18:41 ` [PATCH net-next v4 0/3] net: mpls: fragmentation and gso fixes for locally originated traffic David Miller
2016-08-29 12:07 ` Simon Horman
2016-08-29 12:29 ` Simon Horman
2016-08-29 14:12 ` David Ahern
2016-08-31 5:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472094645-11452-4-git-send-email-dsa@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=alexander.duyck@gmail.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=olivier.dugeon@orange.com \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
--cc=simon.horman@netronome.com \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).