From: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
To: David Miller <davem@davemloft.net>,
tom@herbertland.com, Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
netdev@vger.kernel.org,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
Subject: [PATCH v2 0/1] net: macb: initialize checksum when using checksum
Date: Mon, 29 Aug 2016 15:57:24 +0200 [thread overview]
Message-ID: <1472479045-8814-1-git-send-email-helmut.buchsbaum@gmail.com> (raw)
In-Reply-To: <1471611898-3852-2-git-send-email-helmut.buchsbaum@gmail.com>
When working on upgrading the v3.x kernels of our embedded devices
to more recent 4.x kernels we noticed some of our proprietary networking
stuff is broken. Further investigations brought up an issue with small
UDP packets (data payload <= 2), which contained wrong UDP header
checksums.
We tracked this down to commit 85ff3d87bf2ef1fadcde8553628c60f79806fdb4
net/macb: add TX checksum offload feature.
It turns out that (at least) Zynq's GEM needs the checksum field set to 0
to correctly calculate the checksum.
Changes since v1:
- dropped disabling HW checksum offload for Zynq
- initialize checksum similar to net/ethernet/freescale/fec_main.c
Helmut Buchsbaum (1):
net: macb: initialize checksum when using checksum offloading
drivers/net/ethernet/cadence/macb.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
--
2.1.4
next prev parent reply other threads:[~2016-08-29 13:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 13:04 [PATCH 0/1] HW checksum offload problem on Xilinx Zynq GEM Helmut Buchsbaum
2016-08-19 13:04 ` [PATCH 1/1] net: macb: disable HW checksum offload for Xilinx Zynq Helmut Buchsbaum
2016-08-29 13:57 ` Helmut Buchsbaum [this message]
2016-08-29 13:57 ` [PATCH v2 1/1] net: macb: initialize checksum when using checksum offloading Helmut Buchsbaum
2016-09-01 17:03 ` David Miller
2016-09-04 16:09 ` [PATCH v3] " Helmut Buchsbaum
2016-09-06 20:43 ` David Miller
2016-08-19 19:28 ` [PATCH 0/1] HW checksum offload problem on Xilinx Zynq GEM David Miller
2016-08-19 20:00 ` Tom Herbert
2016-08-23 5:39 ` Helmut Buchsbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472479045-8814-1-git-send-email-helmut.buchsbaum@gmail.com \
--to=helmut.buchsbaum@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=davem@davemloft.net \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).