From: Jeremy Linton <jeremy.linton@arm.com>
To: netdev@vger.kernel.org
Cc: steve.glendinning@shawell.net, sergei.shtylyov@cogentembedded.com
Subject: [PATCH 0/2] net: smsc911x: Move phy and interrupt config
Date: Thu, 1 Sep 2016 11:25:39 -0500 [thread overview]
Message-ID: <1472747141-15886-1-git-send-email-jeremy.linton@arm.com> (raw)
Hi,
The smsc911x driver is doing a number of things in its probe routine that
should be delayed until the interface is started. Because of this, the module
cannot be unloaded, the phy states are incorrect/stale if the interface isn't
running, open's unnecessarily fail causing network configuration problems, and
the /proc/irq nodes are incorrectly named.
Clean up a number of these problems by moving the mdio and interrupt
configuration into the smsc911x_open routine.
Jeremy Linton (2):
net: smsc911x: Fix register_netdev, phy startup, driver unload
ordering
net/smsc911x: Move interrupt allocation to open/stop
drivers/net/ethernet/smsc/smsc911x.c | 89 +++++++++++++++++-------------------
1 file changed, 42 insertions(+), 47 deletions(-)
--
2.5.5
next reply other threads:[~2016-09-01 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 16:25 Jeremy Linton [this message]
2016-09-01 16:25 ` [PATCH 1/2] net: smsc911x: Fix register_netdev, phy startup, driver unload ordering Jeremy Linton
2016-09-01 16:58 ` Andrew Lunn
2016-09-01 18:42 ` Jeremy Linton
2016-09-01 19:22 ` Andrew Lunn
2016-09-01 16:25 ` [PATCH 2/2] net/smsc911x: Move interrupt allocation to open/stop Jeremy Linton
2016-09-01 17:06 ` Andrew Lunn
2016-09-01 18:47 ` Jeremy Linton
2016-09-01 19:45 ` Andrew Lunn
2016-09-01 20:39 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472747141-15886-1-git-send-email-jeremy.linton@arm.com \
--to=jeremy.linton@arm.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).