From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: Phil Sutter <phil@nwl.cc>,
Stephen Hemminger <stephen@networkplumber.org>,
Hangbin Liu <liuhangbin@gmail.com>
Subject: [PATCH iproute2] ip route: check ftell, fseek return value
Date: Tue, 6 Sep 2016 14:39:50 +0800 [thread overview]
Message-ID: <1473143990-9291-1-git-send-email-liuhangbin@gmail.com> (raw)
ftell() may return -1 in error case, which is not handled and therefore pass a
negative offset to fseek(). The return code of fseek() is also not checked.
Reported-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
ip/iproute.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/ip/iproute.c b/ip/iproute.c
index 3da23af..ba877dc 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -1859,7 +1859,11 @@ static int iproute_restore(void)
if (route_dump_check_magic())
exit(-1);
- pos = ftell(stdin);
+ if ((pos = ftell(stdin)) == -1) {
+ perror("Failed to restore: ftell");
+ exit(errno);
+ }
+
for (prio = 0; prio < 3; prio++) {
int err;
@@ -1867,7 +1871,10 @@ static int iproute_restore(void)
if (err)
exit(err);
- fseek(stdin, pos, SEEK_SET);
+ if (fseek(stdin, pos, SEEK_SET) == -1) {
+ perror("Failed to restore: fseek");
+ exit(errno);
+ }
}
exit(0);
--
2.5.5
next reply other threads:[~2016-09-06 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 6:39 Hangbin Liu [this message]
2016-09-06 10:05 ` [PATCH iproute2] ip route: check ftell, fseek return value Phil Sutter
2016-09-06 11:18 ` David Laight
2016-09-07 13:50 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473143990-9291-1-git-send-email-liuhangbin@gmail.com \
--to=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).