From: Joe Perches <joe@perches.com>
To: Woojung.Huh@microchip.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org
Cc: f.fainelli@gmail.com, UNGLinuxDriver@microchip.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros
Date: Tue, 06 Sep 2016 18:18:42 -0700 [thread overview]
Message-ID: <1473211122.29864.1.camel@perches.com> (raw)
In-Reply-To: <9235D6609DB808459E95D78E17F2E43D40910FF9@CHN-SV-EXMX02.mchp-main.com>
On Tue, 2016-09-06 at 23:19 +0000, Woojung.Huh@microchip.com wrote:
> > Joe Perches (2):
> > lan78xx: Remove locally defined trailing underscores from defines and uses
> > microchipphy.h and uses: Remove trailing underscores from defines and
> > uses
> >
> > drivers/net/phy/microchip.c | 4 +-
> > drivers/net/usb/lan78xx.c | 368 +++++++--------
> > drivers/net/usb/lan78xx.h | 1068 +++++++++++++++++++++-----------------
> > ----
> > include/linux/microchipphy.h | 72 +--
> > 4 files changed, 756 insertions(+), 756 deletions(-)
>
>
> Because there is no specific rule how to name defines, I'm not sure it is worth to change 1000+ lines.
> It may be better to set guideline for new submissions.
>
> Welcome any comments.
Generally, more conforming to norms is better.
These FOO_ uses are non-conforming.
Is there anything other than a one-time cost
to apply these? Is the same code used for
other platforms?
next prev parent reply other threads:[~2016-09-07 1:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 23:04 [PATCH 0/2] lan78xx: Remove trailing underscores from macros Joe Perches
2016-09-06 23:04 ` [PATCH 1/2] lan78xx: Remove locally defined trailing underscores from defines and uses Joe Perches
2016-09-06 23:04 ` [PATCH 2/2] microchipphy.h and uses: Remove " Joe Perches
[not found] ` <cover.1473202982.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-09-06 23:19 ` [PATCH 0/2] lan78xx: Remove trailing underscores from macros Woojung.Huh-UWL1GkI3JZL3oGB3hsPCZA
2016-09-07 1:18 ` Joe Perches [this message]
2016-09-07 2:00 ` Ronnie.Kunin
2016-09-07 2:13 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473211122.29864.1.camel@perches.com \
--to=joe@perches.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).