From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net] net_sched: act_mirred: full rcu conversion Date: Fri, 09 Sep 2016 05:23:44 -0700 Message-ID: <1473423824.18970.45.camel@edumazet-glaptop3.roam.corp.google.com> References: <1472795840-31901-1-git-send-email-xiyou.wangcong@gmail.com> <1472795840-31901-6-git-send-email-xiyou.wangcong@gmail.com> <1473173528.10725.14.camel@edumazet-glaptop3.roam.corp.google.com> <57D0FF87.604@gmail.com> <1473341283.15733.33.camel@edumazet-glaptop3.roam.corp.google.com> <1473348943.15733.57.camel@edumazet-glaptop3.roam.corp.google.com> <57D1881B.6090009@gmail.com> <1473349900.15733.59.camel@edumazet-glaptop3.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: John Fastabend , David Miller , Linux Kernel Network Developers , Jamal Hadi Salim , Hadar Hen Zion , Amir Vadai To: Cong Wang Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:36677 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbcIIMXr (ORCPT ); Fri, 9 Sep 2016 08:23:47 -0400 Received: by mail-pf0-f194.google.com with SMTP id x24so3970392pfa.3 for ; Fri, 09 Sep 2016 05:23:47 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2016-09-08 at 22:26 -0700, Cong Wang wrote: > On Thu, Sep 8, 2016 at 8:51 AM, Eric Dumazet wrote: > > On Thu, 2016-09-08 at 08:47 -0700, John Fastabend wrote: > > > >> Works for me. FWIW I find this plenty straightforward and don't really > >> see the need to make the hash table itself rcu friendly. > >> > >> Acked-by: John Fastabend > >> > > > > Yes, it seems this hash table is used in control path, with RTNL held > > anyway. > > Seriously? You never read hashtable in fast path?? I think you need > to wake up. I seriously consider to ignore your mails. Since you write patches with no changelog, expecting us to read your mind, you definitely don't need us.