netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] cxgb4: Fix return value check in cfg_queues_uld()
@ 2016-09-17 15:52 Wei Yongjun
  2016-09-19  5:42 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-09-17 15:52 UTC (permalink / raw)
  To: Hariprasad S; +Cc: Wei Yongjun, netdev

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix the retrn value check which testing the wrong variable
in cfg_queues_uld().

Fixes: 94cdb8bb993a ("cxgb4: Add support for dynamic allocation of
resources for ULD")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
index 5d402ba..4d1de62 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
@@ -245,7 +245,7 @@ int cfg_queues_uld(struct adapter *adap, unsigned int uld_type,
 	}
 
 	rxq_info->rspq_id = kcalloc(nrxq, sizeof(unsigned short), GFP_KERNEL);
-	if (!rxq_info->uldrxq) {
+	if (!rxq_info->rspq_id) {
 		kfree(rxq_info->uldrxq);
 		kfree(rxq_info);
 		return -ENOMEM;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] cxgb4: Fix return value check in cfg_queues_uld()
  2016-09-17 15:52 [PATCH -next] cxgb4: Fix return value check in cfg_queues_uld() Wei Yongjun
@ 2016-09-19  5:42 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-09-19  5:42 UTC (permalink / raw)
  To: weiyj.lk; +Cc: hariprasad, weiyongjun1, netdev

From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Sat, 17 Sep 2016 15:52:17 +0000

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the retrn value check which testing the wrong variable
> in cfg_queues_uld().
> 
> Fixes: 94cdb8bb993a ("cxgb4: Add support for dynamic allocation of
> resources for ULD")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-19  5:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-17 15:52 [PATCH -next] cxgb4: Fix return value check in cfg_queues_uld() Wei Yongjun
2016-09-19  5:42 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).