netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: <netdev@vger.kernel.org>
Subject: [PATCH net-next 0/5] sched: convert queues to single-linked list
Date: Sun, 18 Sep 2016 00:57:29 +0200	[thread overview]
Message-ID: <1474153054-9059-1-git-send-email-fw@strlen.de> (raw)

During Netfilter Workshop 2016 Eric Dumazet pointed out that qdisc
schedulers use doubly-linked lists, even though single-linked list
would be enough.

The double-linked skb lists incur one extra write on enqueue/dequeue
operations (to change ->prev pointer of next list elem).

This series converts qdiscs to single-linked version, listhead
maintains pointers to first (for dequeue) and last skb (for enqueue).

Most qdiscs don't queue at all and instead use a leaf qdisc (typically
pfifo_fast) so only a few schedulers needed changes.

I briefly tested netem and htb and they seemed fine.

UDP_STREAM netperf with 64 byte packets via veth+pfifo_fast shows
a small (~2%) improvement.

Florian Westphal (5):
      pie: use qdisc_dequeue_head wrapper
      sched: don't use skb queue helpers
      sched: remove qdisc arg from __qdisc_dequeue_head
      sched: replace __skb_dequeue with __qdisc_dequeue_head
      sched: add and use qdisc_skb_head helpers

 include/net/sch_generic.h |   72 +++++++++++++++++++++++++++++++++++-----------
 net/sched/sch_codel.c     |    4 +-
 net/sched/sch_fifo.c      |    4 +-
 net/sched/sch_generic.c   |   30 +++++++++++--------
 net/sched/sch_htb.c       |   24 ++++++++++++---
 net/sched/sch_netem.c     |   20 +++++++++---
 net/sched/sch_pie.c       |    4 +-
 7 files changed, 115 insertions(+), 43 deletions(-)

             reply	other threads:[~2016-09-17 22:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-17 22:57 Florian Westphal [this message]
2016-09-17 22:57 ` [PATCH net-next 1/5] pie: use qdisc_dequeue_head wrapper Florian Westphal
2016-09-17 22:57 ` [PATCH net-next 2/5] sched: don't use skb queue helpers Florian Westphal
2016-09-17 22:57 ` [PATCH net-next 3/5] sched: remove qdisc arg from __qdisc_dequeue_head Florian Westphal
2016-09-17 22:57 ` [PATCH net-next 4/5] sched: replace __skb_dequeue with __qdisc_dequeue_head Florian Westphal
2016-09-17 22:57 ` [PATCH net-next 5/5] sched: add and use qdisc_skb_head helpers Florian Westphal
2016-09-19  5:47 ` [PATCH net-next 0/5] sched: convert queues to single-linked list David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474153054-9059-1-git-send-email-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).