From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: davem@davemloft.net, jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, Huaibin Wang <huaibin.wang@6wind.com>,
Scott Feldman <sfeldma@gmail.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Catherine Sullivan <catherine.sullivan@intel.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: [PATCH net] i40e: fix call of ndo_dflt_bridge_getlink()
Date: Mon, 19 Sep 2016 18:14:54 +0200 [thread overview]
Message-ID: <1474301694-13477-1-git-send-email-nicolas.dichtel@6wind.com> (raw)
From: Huaibin Wang <huaibin.wang@6wind.com>
Order of arguments is wrong.
The wrong code has been introduced by commit 7d4f8d871ab1, but is compiled
only since commit 9df70b66418e.
Note that this may break netlink dumps.
Fixes: 9df70b66418e ("i40e: Remove incorrect #ifdef's")
Fixes: 7d4f8d871ab1 ("switchdev; add VLAN support for port's bridge_getlink")
CC: Scott Feldman <sfeldma@gmail.com>
CC: Carolyn Wyborny <carolyn.wyborny@intel.com>
CC: Catherine Sullivan <catherine.sullivan@intel.com>
Signed-off-by: Huaibin Wang <huaibin.wang@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index d0b3a1bb82ca..2843f6cae97a 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -9012,7 +9012,7 @@ static int i40e_ndo_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
return 0;
return ndo_dflt_bridge_getlink(skb, pid, seq, dev, veb->bridge_mode,
- nlflags, 0, 0, filter_mask, NULL);
+ 0, 0, nlflags, filter_mask, NULL);
}
/* Hardware supports L4 tunnel length of 128B (=2^7) which includes
--
2.8.1
next reply other threads:[~2016-09-19 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 16:14 Nicolas Dichtel [this message]
2016-09-23 9:12 ` [PATCH net] i40e: fix call of ndo_dflt_bridge_getlink() Nicolas Dichtel
2016-09-23 21:37 ` Jeff Kirsher
2016-09-26 7:46 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474301694-13477-1-git-send-email-nicolas.dichtel@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=carolyn.wyborny@intel.com \
--cc=catherine.sullivan@intel.com \
--cc=davem@davemloft.net \
--cc=huaibin.wang@6wind.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox