From: Tom Herbert <tom@herbertland.com>
To: <davem@davemloft.net>, <netdev@vger.kernel.org>
Cc: <kernel-team@fb.com>, <tariqt@mellanox.com>,
<bblanco@plumgrid.com>, <alexei.starovoitov@gmail.com>,
<eric.dumazet@gmail.com>, <brouer@redhat.com>
Subject: [PATCH RFC 3/3] netdevice: Remove obsolete xdp_netdev_command
Date: Tue, 20 Sep 2016 15:00:24 -0700 [thread overview]
Message-ID: <1474408824-418864-4-git-send-email-tom@herbertland.com> (raw)
In-Reply-To: <1474408824-418864-1-git-send-email-tom@herbertland.com>
Remove XDP_SETUP_PROG and XDP_QUERY_PROG as they should no longer be
needed.
Signed-off-by: Tom Herbert <tom@herbertland.com>
---
include/linux/netdevice.h | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index f2b7d1b..9a545ab 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -808,18 +808,6 @@ struct tc_to_netdev {
* to the netdevice through the xdp op.
*/
enum xdp_netdev_command {
- /* Set or clear a bpf program used in the earliest stages of packet
- * rx. The prog will have been loaded as BPF_PROG_TYPE_XDP. The callee
- * is responsible for calling bpf_prog_put on any old progs that are
- * stored. In case of error, the callee need not release the new prog
- * reference, but on success it takes ownership and must bpf_prog_put
- * when it is no longer used.
- */
- XDP_SETUP_PROG,
- /* Check if a bpf program is set on the device. The callee should
- * return true if a program is currently attached and running.
- */
- XDP_QUERY_PROG,
/* Initialize XDP in the device. Called the first time an XDP hook
* hook is being set on the device.
*/
@@ -833,10 +821,7 @@ enum xdp_netdev_command {
struct netdev_xdp {
enum xdp_netdev_command command;
union {
- /* XDP_SETUP_PROG */
- struct bpf_prog *prog;
- /* XDP_QUERY_PROG */
- bool prog_attached;
+ /* Command parameters */
};
};
--
2.8.0.rc2
prev parent reply other threads:[~2016-09-20 22:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 22:00 [PATCH RFC 0/3] xdp: Generalize XDP Tom Herbert
2016-09-20 22:00 ` [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP Tom Herbert
2016-09-20 22:37 ` Eric Dumazet
2016-09-20 22:40 ` Tom Herbert
2016-09-20 22:44 ` Thomas Graf
2016-09-20 22:49 ` Tom Herbert
2016-09-20 23:09 ` Thomas Graf
2016-09-20 23:18 ` Tom Herbert
2016-09-20 23:43 ` Thomas Graf
2016-09-20 23:59 ` Tom Herbert
2016-09-21 0:13 ` Alexei Starovoitov
2016-09-21 11:55 ` Thomas Graf
2016-09-21 14:19 ` Tom Herbert
2016-09-21 14:48 ` Thomas Graf
2016-09-21 15:08 ` Tom Herbert
2016-09-21 19:56 ` Jesper Dangaard Brouer
2016-09-22 13:14 ` Jesper Dangaard Brouer
2016-09-22 14:46 ` Eric Dumazet
2016-09-21 15:39 ` Alexei Starovoitov
2016-09-21 17:26 ` Jakub Kicinski
2016-09-20 23:22 ` Daniel Borkmann
2016-09-21 0:01 ` Alexei Starovoitov
2016-09-21 6:39 ` Jesper Dangaard Brouer
2016-09-21 8:42 ` Daniel Borkmann
2016-09-21 15:44 ` Alexei Starovoitov
2016-09-21 17:26 ` Jakub Kicinski
2016-09-21 17:39 ` Tom Herbert
2016-09-21 18:45 ` Jakub Kicinski
2016-09-21 18:50 ` Tom Herbert
2016-09-21 18:54 ` Jakub Kicinski
2016-09-21 18:58 ` Thomas Graf
2016-09-23 11:13 ` Jamal Hadi Salim
2016-09-23 13:00 ` Jesper Dangaard Brouer
2016-09-23 14:26 ` Alexei Starovoitov
2016-09-25 11:32 ` Jamal Hadi Salim
2016-09-23 14:14 ` Tom Herbert
2016-09-25 12:29 ` Jamal Hadi Salim
2016-09-20 22:00 ` [PATCH RFC 2/3] mlx4: Change XDP/BPF to use generic XDP infrastructure Tom Herbert
2016-09-20 22:00 ` Tom Herbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474408824-418864-4-git-send-email-tom@herbertland.com \
--to=tom@herbertland.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bblanco@plumgrid.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).