netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: netdev@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net,
	Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCHv7 net-next 10/15] net: cls_bpf: allow offloaded filters to update stats
Date: Wed, 21 Sep 2016 11:44:02 +0100	[thread overview]
Message-ID: <1474454647-20137-11-git-send-email-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <1474454647-20137-1-git-send-email-jakub.kicinski@netronome.com>

Call into offloaded filters to update stats.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
---
 include/net/pkt_cls.h |  1 +
 net/sched/cls_bpf.c   | 11 +++++++++++
 2 files changed, 12 insertions(+)

diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index 57af9f3032ff..5ccaa4be7d96 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -490,6 +490,7 @@ enum tc_clsbpf_command {
 	TC_CLSBPF_ADD,
 	TC_CLSBPF_REPLACE,
 	TC_CLSBPF_DESTROY,
+	TC_CLSBPF_STATS,
 };
 
 struct tc_cls_bpf_offload {
diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
index 1becc2fe1bc5..bb1d5a487081 100644
--- a/net/sched/cls_bpf.c
+++ b/net/sched/cls_bpf.c
@@ -221,6 +221,15 @@ static void cls_bpf_stop_offload(struct tcf_proto *tp,
 	prog->offloaded = false;
 }
 
+static void cls_bpf_offload_update_stats(struct tcf_proto *tp,
+					 struct cls_bpf_prog *prog)
+{
+	if (!prog->offloaded)
+		return;
+
+	cls_bpf_offload_cmd(tp, prog, TC_CLSBPF_STATS);
+}
+
 static int cls_bpf_init(struct tcf_proto *tp)
 {
 	struct cls_bpf_head *head;
@@ -577,6 +586,8 @@ static int cls_bpf_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
 
 	tm->tcm_handle = prog->handle;
 
+	cls_bpf_offload_update_stats(tp, prog);
+
 	nest = nla_nest_start(skb, TCA_OPTIONS);
 	if (nest == NULL)
 		goto nla_put_failure;
-- 
1.9.1

  parent reply	other threads:[~2016-09-21 10:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 10:43 [PATCHv7 net-next 00/15] BPF hardware offload (cls_bpf for now) Jakub Kicinski
2016-09-21 10:43 ` [PATCHv7 net-next 01/15] net: cls_bpf: add hardware offload Jakub Kicinski
2016-09-21 10:43 ` [PATCHv7 net-next 02/15] net: cls_bpf: limit hardware offload by software-only flag Jakub Kicinski
2016-09-21 10:43 ` [PATCHv7 net-next 03/15] net: cls_bpf: add support for marking filters as hardware-only Jakub Kicinski
2016-09-21 10:43 ` [PATCHv7 net-next 04/15] bpf: don't (ab)use instructions to store state Jakub Kicinski
2016-09-21 10:43 ` [PATCHv7 net-next 05/15] bpf: expose internal verfier structures Jakub Kicinski
2016-09-21 10:43 ` [PATCHv7 net-next 06/15] bpf: enable non-core use of the verfier Jakub Kicinski
2016-09-21 10:43 ` [PATCHv7 net-next 07/15] bpf: recognize 64bit immediate loads as consts Jakub Kicinski
2016-09-21 10:44 ` [PATCHv7 net-next 08/15] nfp: add BPF to NFP code translator Jakub Kicinski
2016-09-21 10:44 ` [PATCHv7 net-next 09/15] nfp: bpf: add hardware bpf offload Jakub Kicinski
2016-09-21 10:44 ` Jakub Kicinski [this message]
2016-09-21 10:44 ` [PATCHv7 net-next 11/15] nfp: bpf: allow offloaded filters to update stats Jakub Kicinski
2016-09-21 10:44 ` [PATCHv7 net-next 12/15] nfp: bpf: add packet marking support Jakub Kicinski
2016-09-21 10:44 ` [PATCHv7 net-next 13/15] net: act_mirred: allow statistic updates from offloaded actions Jakub Kicinski
2016-09-21 10:44 ` [PATCHv7 net-next 14/15] nfp: bpf: add support for legacy redirect action Jakub Kicinski
2016-09-21 10:44 ` [PATCHv7 net-next 15/15] nfp: bpf: add offload of TC direct action mode Jakub Kicinski
2016-09-21 10:48 ` [PATCHv7 net-next 00/15] BPF hardware offload (cls_bpf for now) Jakub Kicinski
2016-09-21 13:35 ` Daniel Borkmann
2016-09-21 23:56 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474454647-20137-11-git-send-email-jakub.kicinski@netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).