* [PATCH -next] net: dsa: qca8k: fix non static symbol warning
@ 2016-09-21 15:04 Wei Yongjun
2016-09-22 7:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-09-21 15:04 UTC (permalink / raw)
To: John Crispin; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/net/dsa/qca8k.c:259:22: warning:
symbol 'qca8k_regmap_config' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/dsa/qca8k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 7f3f178..280acb0 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -256,7 +256,7 @@ static struct regmap_access_table qca8k_readable_table = {
.n_yes_ranges = ARRAY_SIZE(qca8k_readable_ranges),
};
-struct regmap_config qca8k_regmap_config = {
+static struct regmap_config qca8k_regmap_config = {
.reg_bits = 16,
.val_bits = 32,
.reg_stride = 4,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: dsa: qca8k: fix non static symbol warning
2016-09-21 15:04 [PATCH -next] net: dsa: qca8k: fix non static symbol warning Wei Yongjun
@ 2016-09-22 7:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-09-22 7:17 UTC (permalink / raw)
To: weiyj.lk; +Cc: john, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Wed, 21 Sep 2016 15:04:43 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/dsa/qca8k.c:259:22: warning:
> symbol 'qca8k_regmap_config' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-22 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-21 15:04 [PATCH -next] net: dsa: qca8k: fix non static symbol warning Wei Yongjun
2016-09-22 7:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).