From: Sean Wang <sean.wang@mediatek.com>
To: <sergei.shtylyov@cogentembedded.com>
Cc: <john@phrozen.org>, <davem@davemloft.net>, <nbd@openwrt.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <keyhaede@gmail.com>
Subject: Re: [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0
Date: Thu, 22 Sep 2016 23:21:44 +0800 [thread overview]
Message-ID: <1474557704-19011-1-git-send-email-sean.wang@mediatek.com> (raw)
In-Reply-To: <b04e14ff-15db-9cc8-9490-204da8c5837d@cogentembedded.com>
Date: Thu, 22 Sep 2016 14:28:36 +0300, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
>Hello.
>
>On 9/22/2016 5:33 AM, sean.wang@mediatek.com wrote:
>
>> From: Sean Wang <sean.wang@mediatek.com>
>>
>> Add the dts property for the capability if TRGMII supported on GAMC0
>>
>> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
>> ---
>> Documentation/devicetree/bindings/net/mediatek-net.txt | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
>> index 6103e55..7111278 100644
>> --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
>> +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
>> @@ -31,7 +31,10 @@ Optional properties:
>> Required properties:
>> - compatible: Should be "mediatek,eth-mac"
>> - reg: The number of the MAC
>> -- phy-handle: see ethernet.txt file in the same directory.
>> +- phy-handle: see ethernet.txt file in the same directory and
>> + the phy-mode "trgmii" required being provided when reg
>
> Since you've modified the generic parser of the "phy-mode" to add your
>"trgmii", you also need to update ethernet.txt...
>
>> + is equal to 0 and the MAC uses fixed-link to connect
>> + with inernal switch such as MT7530.
>
> Internal.
>
thank you for taking time and effort to review this
I will fix it up
next prev parent reply other threads:[~2016-09-22 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 2:33 [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module sean.wang
2016-09-22 2:33 ` [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII sean.wang
2016-09-22 11:30 ` Sergei Shtylyov
2016-09-23 3:32 ` Sean Wang
2016-09-23 10:19 ` Sergei Shtylyov
2016-09-22 2:33 ` [PATCH net-next v2 2/3] net: ethernet: mediatek: add support for GMAC0 connecting with external PHY through TRGMII sean.wang
[not found] ` <1474511636-11644-1-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-09-22 2:33 ` [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0 sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-09-22 11:28 ` Sergei Shtylyov
2016-09-22 15:21 ` Sean Wang [this message]
2016-09-22 3:17 ` [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module Florian Fainelli
2016-09-22 12:22 ` David Miller
2016-09-22 17:08 ` Sergei Shtylyov
2016-09-23 0:13 ` David Miller
2016-09-23 10:23 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474557704-19011-1-git-send-email-sean.wang@mediatek.com \
--to=sean.wang@mediatek.com \
--cc=davem@davemloft.net \
--cc=john@phrozen.org \
--cc=keyhaede@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).