From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Henry Tieman <henry.w.tieman@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, guru.anbalagane@oracle.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 06/15] i40e: removing unreachable code
Date: Sat, 24 Sep 2016 23:42:40 -0700 [thread overview]
Message-ID: <1474785769-54665-7-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1474785769-54665-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Henry Tieman <henry.w.tieman@intel.com>
The return value from i40e_shutdown_adminq() is always 0
(I40E_SUCCESS). So, the test for non-0 will never be true. Cleanup
by removing the test and debug print statement.
Change-ID: Ie51e8e37515c3e3a6a9ff26fa951d0e5e24343c1
Signed-off-by: Henry Tieman <henry.w.tieman@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 89b0418..e626761b 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -11333,11 +11333,7 @@ static void i40e_remove(struct pci_dev *pdev)
}
/* shutdown the adminq */
- ret_code = i40e_shutdown_adminq(hw);
- if (ret_code)
- dev_warn(&pdev->dev,
- "Failed to destroy the Admin Queue resources: %d\n",
- ret_code);
+ i40e_shutdown_adminq(hw);
/* destroy the locks only once, here */
mutex_destroy(&hw->aq.arq_mutex);
--
2.7.4
next prev parent reply other threads:[~2016-09-25 6:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 6:42 [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-09-24 Jeff Kirsher
2016-09-25 6:42 ` [net-next 01/15] i40e: Remove 100 Mbps SGMII support for X722 Jeff Kirsher
2016-09-25 6:42 ` [net-next 02/15] i40e: fix deleting mac filters Jeff Kirsher
2016-09-25 6:42 ` [net-next 03/15] i40e: add encap csum VF offload flag Jeff Kirsher
2016-09-25 6:42 ` [net-next 04/15] i40e: cleanup ATR auto_disable_flags use Jeff Kirsher
2016-09-25 6:42 ` [net-next 05/15] i40e: check conflicting ntuple/sideband rules when re-enabling ATR Jeff Kirsher
2016-09-25 6:42 ` Jeff Kirsher [this message]
2016-09-25 6:42 ` [net-next 07/15] i40e/i40evf: Changed version to 1.6.16 Jeff Kirsher
2016-09-25 6:42 ` [net-next 08/15] i40e: Increase minimum number of allocated VSI Jeff Kirsher
2016-09-25 6:42 ` [net-next 09/15] i40evf: enable adaptive interrupt throttling Jeff Kirsher
2016-09-25 6:42 ` [net-next 10/15] i40e: Fix Flow Director raw_buf cleanup Jeff Kirsher
2016-09-25 6:42 ` [net-next 11/15] i40e/i40evf: Add txring_txq function to match fm10k and ixgbe Jeff Kirsher
2016-09-25 6:42 ` [net-next 12/15] i40e: Split Flow Director descriptor config into separate function Jeff Kirsher
2016-09-25 6:42 ` [net-next 13/15] i40e: Strip out debugfs hook for Flow Director filter programming Jeff Kirsher
2016-09-25 6:42 ` [net-next 14/15] i40e: don't configure zero-size RSS table Jeff Kirsher
2016-09-25 6:42 ` [net-next 15/15] i40evf: support queue-specific settings for interrupt moderation Jeff Kirsher
2016-09-25 10:01 ` [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-09-24 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474785769-54665-7-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=guru.anbalagane@oracle.com \
--cc=henry.w.tieman@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).