netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Maciej Żenczykowski" <zenczykowski@gmail.com>
To: "Maciej Żenczykowski" <maze@google.com>,
	"David S . Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Erik Kline <ek@google.com>,
	Lorenzo Colitti <lorenzo@google.com>
Subject: [PATCH v3 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl
Date: Sun, 25 Sep 2016 03:52:23 -0700	[thread overview]
Message-ID: <1474800749-2306-2-git-send-email-zenczykowski@gmail.com> (raw)
In-Reply-To: <1474800749-2306-1-git-send-email-zenczykowski@gmail.com>

From: Maciej Żenczykowski <maze@google.com>

Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 net/ipv6/addrconf.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 2f1f5d439788..11fa1a5564d4 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -6044,8 +6044,14 @@ static int __addrconf_sysctl_register(struct net *net, char *dev_name,
 
 	for (i = 0; table[i].data; i++) {
 		table[i].data += (char *)p - (char *)&ipv6_devconf;
-		table[i].extra1 = idev; /* embedded; no ref */
-		table[i].extra2 = net;
+		/* If one of these is already set, then it is not safe to
+		 * overwrite either of them: this makes proc_dointvec_minmax
+		 * usable.
+		 */
+		if (!table[i].extra1 && !table[i].extra2) {
+			table[i].extra1 = idev; /* embedded; no ref */
+			table[i].extra2 = net;
+		}
 	}
 
 	snprintf(path, sizeof(path), "net/ipv6/conf/%s", dev_name);
-- 
2.8.0.rc3.226.g39d4020

  reply	other threads:[~2016-09-25 10:52 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-24 16:01 Implement rfc7559 ipv6 router solicitation backoff Maciej Żenczykowski
2016-09-24 16:05 ` [PATCH 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl Maciej Żenczykowski
2016-09-24 16:05   ` [PATCH 2/7] ipv6 addrconf: remove addrconf_sysctl_hop_limit() Maciej Żenczykowski
2016-09-24 16:05   ` [PATCH 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited Maciej Żenczykowski
2016-09-24 16:05   ` [PATCH 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval' Maciej Żenczykowski
2016-09-24 16:05   ` [PATCH 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff Maciej Żenczykowski
2016-09-25  2:14     ` Maciej Żenczykowski
2016-09-25  2:14       ` [PATCH] " Maciej Żenczykowski
2016-09-25  9:33         ` David Miller
2016-09-25  9:59           ` [PATCH v2 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl Maciej Żenczykowski
2016-09-25  9:59             ` [PATCH v2 2/7] ipv6 addrconf: remove addrconf_sysctl_hop_limit() Maciej Żenczykowski
2016-09-25  9:59             ` [PATCH v2 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited Maciej Żenczykowski
2016-09-26 15:34               ` Lorenzo Colitti
2016-09-27  2:23                 ` Maciej Żenczykowski
2016-09-27  2:25                   ` Erik Kline
2016-09-25  9:59             ` [PATCH v2 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval' Maciej Żenczykowski
2016-09-25  9:59             ` [PATCH v2 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff Maciej Żenczykowski
2016-09-25  9:59             ` [PATCH v2 6/7] ipv6 addrconf: change default RTR_SOLICITATION_MAX_INTERVAL from 4s to 1h Maciej Żenczykowski
2016-09-25  9:59             ` [PATCH v2 7/7] ipv6 addrconf: change default MAX_RTR_SOLICITATIONS from 3 to -1 (unlimited) Maciej Żenczykowski
2016-09-25 10:04             ` [PATCH v2 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl David Miller
2016-09-25 10:52               ` (unknown), Maciej Żenczykowski
2016-09-25 10:52                 ` Maciej Żenczykowski [this message]
2016-09-25 10:52                 ` [PATCH v3 2/7] ipv6 addrconf: remove addrconf_sysctl_hop_limit() Maciej Żenczykowski
2016-09-25 10:52                 ` [PATCH v3 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited Maciej Żenczykowski
2016-09-25 10:52                 ` [PATCH v3 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval' Maciej Żenczykowski
2016-09-25 10:52                 ` [PATCH v3 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff Maciej Żenczykowski
2016-09-25 10:52                 ` [PATCH v3 6/7] ipv6 addrconf: change default RTR_SOLICITATION_MAX_INTERVAL from 4s to 1h Maciej Żenczykowski
2016-09-25 10:52                 ` [PATCH v3 7/7] ipv6 addrconf: change default MAX_RTR_SOLICITATIONS from 3 to -1 (unlimited) Maciej Żenczykowski
2016-09-25 12:51                 ` (unknown) David Miller
2016-09-25 11:03               ` [PATCH v4 0/7] implement rfc7559 ipv6 router solicitation backoff Maciej Żenczykowski
2016-09-25 11:03                 ` [PATCH v4 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl Maciej Żenczykowski
2016-09-26  9:13                   ` Erik Kline
2016-09-25 11:03                 ` [PATCH v4 2/7] ipv6 addrconf: remove addrconf_sysctl_hop_limit() Maciej Żenczykowski
2016-09-26  9:14                   ` Erik Kline
2016-09-26  9:37                     ` Maciej Żenczykowski
2016-09-25 11:03                 ` [PATCH v4 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited Maciej Żenczykowski
2016-09-26  9:23                   ` Erik Kline
2016-09-25 11:03                 ` [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval' Maciej Żenczykowski
2016-09-26  9:29                   ` Erik Kline
2016-09-26 13:59                   ` Hannes Frederic Sowa
2016-09-27  2:30                     ` Maciej Żenczykowski
2016-09-27  9:49                       ` Hannes Frederic Sowa
2016-09-27 10:08                         ` Maciej Żenczykowski
2016-09-25 11:03                 ` [PATCH v4 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff Maciej Żenczykowski
2016-09-26 13:53                   ` Hannes Frederic Sowa
2016-09-27  9:42                     ` Maciej Żenczykowski
2016-09-27  9:52                       ` [PATCH v5 0/7] implement rfc7559 ipv6 " Maciej Żenczykowski
2016-09-27  9:52                         ` [PATCH v5 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl Maciej Żenczykowski
2016-09-27 10:16                           ` YOSHIFUJI Hideaki
2016-09-27  9:52                         ` [PATCH v5 2/7] ipv6 addrconf: remove addrconf_sysctl_hop_limit() Maciej Żenczykowski
2016-09-27 10:18                           ` YOSHIFUJI Hideaki
2016-09-27  9:52                         ` [PATCH v5 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited Maciej Żenczykowski
2016-09-27 10:20                           ` YOSHIFUJI Hideaki
2016-09-27 10:39                             ` Maciej Żenczykowski
2016-09-27  9:52                         ` [PATCH v5 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval' Maciej Żenczykowski
2016-09-27  9:52                         ` [PATCH v5 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff Maciej Żenczykowski
2016-09-27  9:52                         ` [PATCH v5 6/7] ipv6 addrconf: change default RTR_SOLICITATION_MAX_INTERVAL from 4s to 1h Maciej Żenczykowski
2016-09-27  9:52                         ` [PATCH v5 7/7] ipv6 addrconf: change default MAX_RTR_SOLICITATIONS from 3 to -1 (unlimited) Maciej Żenczykowski
2016-09-27  9:58                       ` [PATCH v4 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff Hannes Frederic Sowa
2016-09-27 10:20                       ` Hannes Frederic Sowa
2016-09-25 11:03                 ` [PATCH v4 6/7] ipv6 addrconf: change default RTR_SOLICITATION_MAX_INTERVAL from 4s to 1h Maciej Żenczykowski
2016-09-25 11:03                 ` [PATCH v4 7/7] ipv6 addrconf: change default MAX_RTR_SOLICITATIONS from 3 to -1 (unlimited) Maciej Żenczykowski
2016-09-24 16:05   ` [PATCH 6/7] ipv6 addrconf: change default RTR_SOLICITATION_MAX_INTERVAL from 4s to 1h Maciej Żenczykowski
2016-09-24 16:05   ` [PATCH 7/7] ipv6 addrconf: change default MAX_RTR_SOLICITATIONS from 3 to -1 (unlimited) Maciej Żenczykowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474800749-2306-2-git-send-email-zenczykowski@gmail.com \
    --to=zenczykowski@gmail.com \
    --cc=davem@davemloft.net \
    --cc=ek@google.com \
    --cc=lorenzo@google.com \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).