* [PATCH net-next 2/2] net: ethernet: mediatek: bug fix to disable HW LRO
[not found] ` <1474871630-4134-1-git-send-email-nelson.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2016-09-26 6:33 ` Nelson Chang
2016-09-26 11:21 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Nelson Chang @ 2016-09-26 6:33 UTC (permalink / raw)
To: john-Pj+rj9U5foFAfugRpC6u6w, davem-fT/PcQaiUtIeIZ0/mPfg9Q
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, nbd-p3rKhJxN3npAfugRpC6u6w,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
nelsonch.tw-Re5JQEeQqe8AvxtiuMwx3w, Nelson Chang
(1) Modify the register settings for LRO relinquishments
(2) Jump out from the waiting loop while LRO relinquishments are done
Signed-off-by: Nelson Chang <nelson.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 +
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 62de68d..ddf20a0 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1374,6 +1374,7 @@ static void mtk_hwlro_rx_uninit(struct mtk_eth *eth)
msleep(20);
continue;
}
+ break;
}
/* invalidate lro rings */
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h
index 7e194f7..3003195 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h
@@ -102,8 +102,8 @@
#define MTK_LRO_EN BIT(0)
#define MTK_L3_CKS_UPD_EN BIT(7)
#define MTK_LRO_ALT_PKT_CNT_MODE BIT(21)
-#define MTK_LRO_RING_RELINQUISH_REQ (0x3 << 26)
-#define MTK_LRO_RING_RELINQUISH_DONE (0x3 << 29)
+#define MTK_LRO_RING_RELINQUISH_REQ (0x7 << 26)
+#define MTK_LRO_RING_RELINQUISH_DONE (0x7 << 29)
#define MTK_PDMA_LRO_CTRL_DW1 0x984
#define MTK_PDMA_LRO_CTRL_DW2 0x988
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 2/2] net: ethernet: mediatek: bug fix to disable HW LRO
2016-09-26 6:33 ` [PATCH net-next 2/2] net: ethernet: mediatek: bug fix to disable " Nelson Chang
@ 2016-09-26 11:21 ` Sergei Shtylyov
0 siblings, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-09-26 11:21 UTC (permalink / raw)
To: Nelson Chang, john, davem; +Cc: nbd, netdev, linux-mediatek, nelsonch.tw
Hello.
On 9/26/2016 9:33 AM, Nelson Chang wrote:
> (1) Modify the register settings for LRO relinquishments
> (2) Jump out from the waiting loop while LRO relinquishments are done
Why this is done in a single patch?
> Signed-off-by: Nelson Chang <nelson.chang@mediatek.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net-next 2/2] net: ethernet: mediatek: bug fix to disable HW LRO
@ 2016-09-26 11:43 Nelson Chang
0 siblings, 0 replies; 3+ messages in thread
From: Nelson Chang @ 2016-09-26 11:43 UTC (permalink / raw)
To: sergei.shtylyov, john, davem; +Cc: nbd, netdev, linux-mediatek, nelsonch.tw
Hi Sergei,
Because these modifications are both related to LRO relinquishments, I
put them in a single patch.
Nelson
-----Original Message-----
From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
Sent: Monday, September 26, 2016 7:21 PM
To: Nelson Chang (張家祥); john@phrozen.org; davem@davemloft.net
Cc: nbd@openwrt.org; netdev@vger.kernel.org;
linux-mediatek@lists.infradead.org; nelsonch.tw@gmail.com
Subject: Re: [PATCH net-next 2/2] net: ethernet: mediatek: bug fix to
disable HW LRO
Hello.
On 9/26/2016 9:33 AM, Nelson Chang wrote:
> (1) Modify the register settings for LRO relinquishments
> (2) Jump out from the waiting loop while LRO relinquishments are done
Why this is done in a single patch?
> Signed-off-by: Nelson Chang <nelson.chang@mediatek.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-26 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26 11:43 [PATCH net-next 2/2] net: ethernet: mediatek: bug fix to disable HW LRO Nelson Chang
-- strict thread matches above, loose matches on Subject: below --
2016-09-26 6:33 [PATCH net-next 0/2] net: ethernet: mediatek: some bug fixes for PDAM and " Nelson Chang
[not found] ` <1474871630-4134-1-git-send-email-nelson.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-09-26 6:33 ` [PATCH net-next 2/2] net: ethernet: mediatek: bug fix to disable " Nelson Chang
2016-09-26 11:21 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).