From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tilman Schmidt Subject: Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure Date: Tue, 27 Sep 2016 14:08:03 +0200 Message-ID: <1474978083.1622422.738355481.4ACE5312@webmail.messagingengine.com> References: <566ABCD9.1060404@users.sourceforge.net> <6d4bbb77-914f-19b8-a1a9-2731d1158612@users.sourceforge.net> <6409b3b0-3b7a-1139-f040-7b1a61611187@users.sourceforge.net> <1474924434.8546.29.camel@tiscali.nl> <0d02085e-842c-4be9-f706-c43b38ce9095@users.sourceforge.net> <1474966121.9970.5.camel@tiscali.nl> <1474971962.1601897.738261385.73EB49E0@webmail.messagingengine.com> <5974a2c5-2739-cd69-6e37-04a645bc08d7@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Paul Bolle , Karsten Keil , gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, LKML , Julia Lawall To: SF Markus Elfring Return-path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:37242 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932624AbcI0MIF (ORCPT ); Tue, 27 Sep 2016 08:08:05 -0400 In-Reply-To: <5974a2c5-2739-cd69-6e37-04a645bc08d7@users.sourceforge.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Sep 27, 2016, at 13:32, SF Markus Elfring wrote: > >> I got the impression that the exception handling was incomplete in the > >> implementation of the function "gigaset_initcs". > > > > That impression is wrong. Careful reading of the code will confirm that. > > * Is it still correct nowadays that the function "gigaset_initcs" did not > call the function "kfree" after a later function call failed? Wrong premise. That statement was never correct. > * Do you expect that allocated memory will be automatically reclaimed > after it would return a null pointer? No. Should I? Do you? Regards, Tilman -- Tilman Schmidt tilman@imap.cc