From: Jia He <hejianet@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
marcelo.leitner@gmail.com, Jia He <hejianet@gmail.com>
Subject: [PATCH v6 1/7] net:snmp: Introduce generic interfaces for snmp_get_cpu_field{,64}
Date: Fri, 30 Sep 2016 11:28:58 +0800 [thread overview]
Message-ID: <1475206144-23228-2-git-send-email-hejianet@gmail.com> (raw)
In-Reply-To: <1475206144-23228-1-git-send-email-hejianet@gmail.com>
This is to introduce the generic interfaces for snmp_get_cpu_field{,64}.
It exchanges the two for-loops for collecting the percpu statistics data.
This can aggregate the data by going through all the items of each cpu
sequentially.
Signed-off-by: Jia He <hejianet@gmail.com>
Suggested-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
include/net/ip.h | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/include/net/ip.h b/include/net/ip.h
index 9742b92..bc43c0f 100644
--- a/include/net/ip.h
+++ b/include/net/ip.h
@@ -219,6 +219,29 @@ static inline u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_o
}
#endif
+#define snmp_get_cpu_field64_batch(buff64, stats_list, mib_statistic, offset) \
+{ \
+ int i, c; \
+ for_each_possible_cpu(c) { \
+ for (i = 0; stats_list[i].name; i++) \
+ buff64[i] += snmp_get_cpu_field64( \
+ mib_statistic, \
+ c, stats_list[i].entry, \
+ offset); \
+ } \
+}
+
+#define snmp_get_cpu_field_batch(buff, stats_list, mib_statistic) \
+{ \
+ int i, c; \
+ for_each_possible_cpu(c) { \
+ for (i = 0; stats_list[i].name; i++) \
+ buff[i] += snmp_get_cpu_field( \
+ mib_statistic, \
+ c, stats_list[i].entry); \
+ } \
+}
+
void inet_get_local_port_range(struct net *net, int *low, int *high);
#ifdef CONFIG_SYSCTL
--
2.5.5
next prev parent reply other threads:[~2016-09-30 3:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 3:28 [PATCH v6 0/7] Reduce cache miss for snmp_fold_field Jia He
2016-09-30 3:28 ` Jia He [this message]
2016-09-30 3:28 ` [PATCH v6 2/7] proc: Reduce cache miss in snmp_seq_show Jia He
2016-09-30 3:29 ` [PATCH v6 3/7] proc: Reduce cache miss in snmp6_seq_show Jia He
2016-09-30 3:29 ` [PATCH v6 4/7] proc: Reduce cache miss in sctp_snmp_seq_show Jia He
2016-09-30 3:29 ` [PATCH v6 5/7] proc: Reduce cache miss in xfrm_statistics_seq_show Jia He
2016-09-30 3:29 ` [PATCH v6 6/7] ipv6: Remove useless parameter in __snmp6_fill_statsdev Jia He
2016-09-30 3:29 ` [PATCH v6 7/7] net: Suppress the "Comparison to NULL could be written" warnings Jia He
2016-09-30 6:14 ` [PATCH v6 0/7] Reduce cache miss for snmp_fold_field David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475206144-23228-2-git-send-email-hejianet@gmail.com \
--to=hejianet@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=steffen.klassert@secunet.com \
--cc=vyasevich@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).