From: Xander Huff <xander.huff@ni.com>
To: nicolas.ferre@atmel.com
Cc: netdev@vger.kernel.org, Nathan Sullivan <nathan.sullivan@ni.com>,
linux-kernel@vger.kernel.org, xander.huff@ni.com,
Brad Mouring <brad.mouring@ni.com>
Subject: [PATCH] net: macb: NULL out phydev after removing mdio bus
Date: Fri, 7 Oct 2016 10:13:22 -0500 [thread overview]
Message-ID: <1475853202-19903-1-git-send-email-xander.huff@ni.com> (raw)
From: Nathan Sullivan <nathan.sullivan@ni.com>
To ensure the dev->phydev pointer is not used after becoming invalid in
mdiobus_unregister, set it to NULL. This happens when removing the macb
driver without first taking its interface down, since unregister_netdev
will end up calling macb_close.
Signed-off-by: Xander Huff <xander.huff@ni.com>
Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
Signed-off-by: Brad Mouring <brad.mouring@ni.com>
---
drivers/net/ethernet/cadence/macb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 63144bb..b32444a 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -3117,6 +3117,7 @@ static int macb_remove(struct platform_device *pdev)
if (dev->phydev)
phy_disconnect(dev->phydev);
mdiobus_unregister(bp->mii_bus);
+ dev->phydev = NULL;
mdiobus_free(bp->mii_bus);
/* Shutdown the PHY if there is a GPIO reset */
--
1.9.1
next reply other threads:[~2016-10-07 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 15:13 Xander Huff [this message]
2016-10-07 15:20 ` [PATCH] net: macb: NULL out phydev after removing mdio bus Moritz Fischer
2016-10-07 16:22 ` Nicolas Ferre
2016-10-08 3:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475853202-19903-1-git-send-email-xander.huff@ni.com \
--to=xander.huff@ni.com \
--cc=brad.mouring@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan.sullivan@ni.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).