From: Johannes Berg <johannes@sipsolutions.net>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andy Lutomirski <luto@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-next@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)
Date: Wed, 12 Oct 2016 11:05:06 +0200 [thread overview]
Message-ID: <1476263106.5271.23.camel@sipsolutions.net> (raw)
In-Reply-To: <20161010153050.GA836@swordfish> (sfid-20161010_173147_270639_33210BFD)
Hi,
Sorry - I meant to look into this yesterday but forgot.
> Andy, can this be related to CONFIG_VMAP_STACK?
I think it is.
> > current -git kills my system.
Can you elaborate on how exactly it kills your system?
> > adding
> >
> > if (!virt_addr_valid(&aad[2])) {
> > WARN_ON(1);
> > return -EINVAL;
> > }
That's pretty obviously false with VMAP_STACK, since the caller
(ieee80211_crypto_ccmp_decrypt) puts the aad on the stack. b_0 is also
on the stack, but maybe that doesn't matter.
Herbert, do you know what could cause this, and how we should fix it?
We can't really afford to do an allocation here, and we don't have
space in the skb (not even in skb->cb at that point), so if we really
have no way to continue using the stack we'd ... not sure, use a per-
CPU buffer perhaps.
We need 32 bytes for aad and 16 bytes for b_0, if that also can't be on
the stack any more.
johannes
next prev parent reply other threads:[~2016-10-12 9:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 15:03 [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) Sergey Senozhatsky
2016-10-10 15:30 ` Sergey Senozhatsky
2016-10-12 9:05 ` Johannes Berg [this message]
2016-10-12 14:12 ` Sergey Senozhatsky
2016-10-12 14:22 ` Johannes Berg
2016-10-13 5:39 ` Andy Lutomirski
2016-10-13 6:02 ` Johannes Berg
2016-10-13 13:42 ` Sergey Senozhatsky
2016-10-13 13:45 ` Sergey Senozhatsky
2016-10-13 13:45 ` Johannes Berg
2016-10-13 15:00 ` Sergey Senozhatsky
2016-10-13 15:04 ` Sergey Senozhatsky
2016-10-13 21:49 ` Andy Lutomirski
2016-10-14 7:25 ` Johannes Berg
2016-10-14 8:28 ` Johannes Berg
2016-10-14 8:39 ` Ard Biesheuvel
2016-10-14 8:41 ` Ard Biesheuvel
2016-10-14 8:42 ` Johannes Berg
2016-10-14 8:47 ` Ard Biesheuvel
[not found] ` <CAKv+Gu896xme5sd5i8hs7tA=Xt=qQKCiAx7fQg1ZECn50NttbQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-14 8:55 ` Johannes Berg
2016-10-14 9:05 ` Ard Biesheuvel
2016-10-14 9:10 ` Johannes Berg
2016-10-14 9:21 ` Ard Biesheuvel
2016-10-14 9:25 ` Johannes Berg
2016-10-14 9:35 ` Ard Biesheuvel
2016-10-14 10:00 ` Johannes Berg
2016-10-14 11:11 ` Ard Biesheuvel
2016-10-14 8:53 ` Johannes Berg
2016-10-14 8:39 ` Sergey Senozhatsky
2016-10-14 8:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476263106.5271.23.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luto@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).