From: Johannes Berg <johannes@sipsolutions.net>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"<linux-wireless@vger.kernel.org>"
<linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack
Date: Fri, 14 Oct 2016 15:46:32 +0200 [thread overview]
Message-ID: <1476452792.31114.46.camel@sipsolutions.net> (raw)
In-Reply-To: <CAKv+Gu81RYq1aZUQ2Aru3Vev4LGgb1zFwWz8gepE0tQEhQi9Uw@mail.gmail.com> (sfid-20161014_151923_585451_B0D65F1F)
>
> Is the aad[] actually reused? I would assume it only affects the mac
> on encryption, and the verification on decryption but I don't think
> we actually need it back from the crypto routines.
I don't think it's reused.
> Exactly what you said above :-) My patch only touches CCM but as you
> said,
>
> """
> 'Also there's B_0/J_0 for CCM/GCM, and the 'zero' thing that GMAC
> has.
> """
Ah, but we can/should do the same for the others, no?
johannes
next prev parent reply other threads:[~2016-10-14 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 13:09 [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel
[not found] ` <1476450540-1760-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-14 13:10 ` Johannes Berg
2016-10-14 13:11 ` Johannes Berg
[not found] ` <1476450635.31114.42.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-10-14 13:13 ` Ard Biesheuvel
2016-10-14 13:15 ` Johannes Berg
2016-10-14 13:19 ` Ard Biesheuvel
2016-10-14 13:46 ` Johannes Berg [this message]
[not found] ` <1476452792.31114.46.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-10-14 14:22 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476452792.31114.46.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=j@w1.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).