From: Paolo Abeni <pabeni@redhat.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Doug Ledford <dledford@redhat.com>,
Erez Shitrit <erezsh@mellanox.com>,
Alex Vesker <valex@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Linux Netdev List <netdev@vger.kernel.org>,
"talal@mellanox.com" <talal@mellanox.com>
Subject: Re: [PATCH v3] IB/ipoib: move back IB LL address into the hard header
Date: Fri, 14 Oct 2016 16:48:50 +0200 [thread overview]
Message-ID: <1476456530.5591.1.camel@redhat.com> (raw)
In-Reply-To: <CAJ3xEMi7DY7_3vM+553dC4w17W==CdUdtn5PdzzCCUxtj434dQ@mail.gmail.com>
On Fri, 2016-10-14 at 13:23 +0300, Or Gerlitz wrote:
>
> Paolo,
>
> Is this fix backportable to any kernel since the breakage?
yes, AFAIK this is beck-portable.
> AFAIR,
> Roland mentioned
> that a 2nd change introduced in 4.7-rc1 changed things a bit more such
> that the fix
> he had in his head didn't apply any more.
If you refer to shrinking both IPoIB and gso control buffer, as proposed
by Roland in:
http://marc.info/?l=linux-kernel&m=146787279825501&w=2
that will not work, since the gso control buffer is grown a bit since
the first time the bug was detected.
This patch does not have that sort of issue.
> I am still travelling after netdev and would like to put an eye on the
> patch and also see that @mellanox.com someone
Not sure if that helps, but a 3rd party has already confirmed privately
that this patch fixes the bug for them.
Paolo
next prev parent reply other threads:[~2016-10-14 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 16:26 [PATCH v3] IB/ipoib: move back IB LL address into the hard header Paolo Abeni
[not found] ` <9fce9b87ecc4c5c4f03401359806f40b1dcd0eb3.1476374992.git.pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-14 10:23 ` Or Gerlitz
2016-10-14 14:48 ` Paolo Abeni [this message]
2016-10-14 14:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476456530.5591.1.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=erezsh@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=hal.rosenstock@gmail.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=talal@mellanox.com \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).