From: Johannes Berg <johannes@sipsolutions.net>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "<linux-wireless@vger.kernel.org>"
<linux-wireless@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v4] mac80211: move extra crypto data off the stack
Date: Mon, 17 Oct 2016 15:25:06 +0200 [thread overview]
Message-ID: <1476710706.315.2.camel@sipsolutions.net> (raw)
In-Reply-To: <CAKv+Gu_jdiQn+o5PAZmPfMsQYt8PsOkDE6YNU11VH9WM_QPcvg@mail.gmail.com> (sfid-20161017_152040_808548_79392877)
> Indeed. And it keeps the clutter inside the aes_xxx.c files, which
> could easily be updated in the future to use some auxdata feature if
> it ever materializes.
>
> I think it would help this code, but also the ESP code you pointed
> out, to have some kind of 'ordered synchronous' CRYPTO_xxx flag,
> where the crypto API could manage the kmem cache and percpu pointers
> to allocations.
Yeah, could be useful to have that more generally.
> This goes well beyond what we can do as a fix, though, so we need an
> intermediate solution in any case.
>
> Shall I propose the patch?
I assume you mean a mac80211 patch - sure, I'll take that instead of
the two I have now.
johannes
prev parent reply other threads:[~2016-10-17 13:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 8:33 [PATCH v4] mac80211: move extra crypto data off the stack Johannes Berg
2016-10-17 9:14 ` Ard Biesheuvel
2016-10-17 9:17 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-aZhCBvnEQoZUZLDPXCrvgxO1pSd=6EHz+tMB+dFz5hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-17 9:23 ` Johannes Berg
2016-10-17 9:30 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_ZH9hO_xbVfOfk90CxFJ6ZTz3PKWB1v23LRVzpBrb=oQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-17 9:35 ` Johannes Berg
[not found] ` <1476696918.19992.15.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-10-17 9:49 ` Ard Biesheuvel
2016-10-17 9:52 ` Ard Biesheuvel
[not found] ` <67161BCC-596E-4DDE-A58E-9195BB5570C2-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-17 9:54 ` Johannes Berg
2016-10-17 10:02 ` Ard Biesheuvel
[not found] ` <41D0AC2F-E86E-4A98-AD8B-1239D7E6123A-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-17 13:06 ` Ard Biesheuvel
2016-10-17 13:16 ` Johannes Berg
[not found] ` <1476710169.315.1.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-10-17 13:20 ` Ard Biesheuvel
2016-10-17 13:25 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476710706.315.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ard.biesheuvel@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).