* [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code
@ 2016-10-17 14:50 Wei Yongjun
2016-10-17 17:09 ` David Miller
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Wei Yongjun @ 2016-10-17 14:50 UTC (permalink / raw)
To: Javier Martinez Canillas, Zhao Qiang; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
module_spi_driver() makes the code simpler by eliminating
boilerplate code.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wan/slic_ds26522.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/net/wan/slic_ds26522.c b/drivers/net/wan/slic_ds26522.c
index b776a0a..8f782f1 100644
--- a/drivers/net/wan/slic_ds26522.c
+++ b/drivers/net/wan/slic_ds26522.c
@@ -249,15 +249,4 @@ static struct spi_driver slic_ds26522_driver = {
.id_table = slic_ds26522_id,
};
-static int __init slic_ds26522_init(void)
-{
- return spi_register_driver(&slic_ds26522_driver);
-}
-
-static void __exit slic_ds26522_exit(void)
-{
- spi_unregister_driver(&slic_ds26522_driver);
-}
-
-module_init(slic_ds26522_init);
-module_exit(slic_ds26522_exit);
+module_spi_driver(slic_ds26522_driver);
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code
2016-10-17 14:50 [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code Wei Yongjun
@ 2016-10-17 17:09 ` David Miller
2016-10-17 20:38 ` Javier Martinez Canillas
2017-02-06 15:25 ` [PATCH net-next v2] " Wei Yongjun
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2016-10-17 17:09 UTC (permalink / raw)
To: weiyj.lk; +Cc: javier, qiang.zhao, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Mon, 17 Oct 2016 14:50:45 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> module_spi_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
These two patches do not apply cleanly to net-next, please respin.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code
2016-10-17 14:50 [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code Wei Yongjun
2016-10-17 17:09 ` David Miller
@ 2016-10-17 20:38 ` Javier Martinez Canillas
2017-02-06 15:25 ` [PATCH net-next v2] " Wei Yongjun
2 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 20:38 UTC (permalink / raw)
To: Wei Yongjun, Zhao Qiang; +Cc: Wei Yongjun, netdev
Hello Wei,
On 10/17/2016 11:50 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> module_spi_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/wan/slic_ds26522.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/net/wan/slic_ds26522.c b/drivers/net/wan/slic_ds26522.c
> index b776a0a..8f782f1 100644
> --- a/drivers/net/wan/slic_ds26522.c
> +++ b/drivers/net/wan/slic_ds26522.c
> @@ -249,15 +249,4 @@ static struct spi_driver slic_ds26522_driver = {
> .id_table = slic_ds26522_id,
> };
>
> -static int __init slic_ds26522_init(void)
> -{
> - return spi_register_driver(&slic_ds26522_driver);
> -}
> -
> -static void __exit slic_ds26522_exit(void)
> -{
> - spi_unregister_driver(&slic_ds26522_driver);
> -}
> -
> -module_init(slic_ds26522_init);
> -module_exit(slic_ds26522_exit);
> +module_spi_driver(slic_ds26522_driver);
>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH net-next v2] net: wan: slic_ds26522: Use module_spi_driver to simplify the code
2016-10-17 14:50 [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code Wei Yongjun
2016-10-17 17:09 ` David Miller
2016-10-17 20:38 ` Javier Martinez Canillas
@ 2017-02-06 15:25 ` Wei Yongjun
2017-02-07 16:42 ` David Miller
2 siblings, 1 reply; 5+ messages in thread
From: Wei Yongjun @ 2017-02-06 15:25 UTC (permalink / raw)
To: Javier Martinez Canillas, Zhao Qiang, Colin Ian King; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
module_spi_driver() makes the code simpler by eliminating
boilerplate code.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wan/slic_ds26522.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/net/wan/slic_ds26522.c b/drivers/net/wan/slic_ds26522.c
index 9d9b4e0..2cdcee2 100644
--- a/drivers/net/wan/slic_ds26522.c
+++ b/drivers/net/wan/slic_ds26522.c
@@ -249,15 +249,4 @@ static struct spi_driver slic_ds26522_driver = {
.id_table = slic_ds26522_id,
};
-static int __init slic_ds26522_init(void)
-{
- return spi_register_driver(&slic_ds26522_driver);
-}
-
-static void __exit slic_ds26522_exit(void)
-{
- spi_unregister_driver(&slic_ds26522_driver);
-}
-
-module_init(slic_ds26522_init);
-module_exit(slic_ds26522_exit);
+module_spi_driver(slic_ds26522_driver);
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next v2] net: wan: slic_ds26522: Use module_spi_driver to simplify the code
2017-02-06 15:25 ` [PATCH net-next v2] " Wei Yongjun
@ 2017-02-07 16:42 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-02-07 16:42 UTC (permalink / raw)
To: weiyj.lk; +Cc: javier, qiang.zhao, colin.king, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Mon, 6 Feb 2017 15:25:52 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> module_spi_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-07 16:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 14:50 [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code Wei Yongjun
2016-10-17 17:09 ` David Miller
2016-10-17 20:38 ` Javier Martinez Canillas
2017-02-06 15:25 ` [PATCH net-next v2] " Wei Yongjun
2017-02-07 16:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).