* [PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open()
@ 2016-10-17 15:31 Wei Yongjun
2016-10-17 15:35 ` Måns Rullgård
2016-10-17 17:12 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-10-17 15:31 UTC (permalink / raw)
To: jarod, sf84, peter.chen, mans, tremyfr, arnd, f.fainelli
Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return error code -ENODEV from the of_phy_connect() error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/aurora/nb8800.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index 453dc09..99c4055 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -975,8 +975,10 @@ static int nb8800_open(struct net_device *dev)
phydev = of_phy_connect(dev, priv->phy_node,
nb8800_link_reconfigure, 0,
priv->phy_mode);
- if (!phydev)
+ if (!phydev) {
+ err = -ENODEV;
goto err_free_irq;
+ }
nb8800_pause_adv(dev);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open()
2016-10-17 15:31 [PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open() Wei Yongjun
@ 2016-10-17 15:35 ` Måns Rullgård
2016-10-17 17:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Måns Rullgård @ 2016-10-17 15:35 UTC (permalink / raw)
To: Wei Yongjun
Cc: jarod, sf84, peter.chen, tremyfr, arnd, f.fainelli, Wei Yongjun,
netdev
Wei Yongjun <weiyj.lk@gmail.com> writes:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENODEV from the of_phy_connect() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Mans Rullgard <mans@mansr.com>
> ---
> drivers/net/ethernet/aurora/nb8800.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
> index 453dc09..99c4055 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -975,8 +975,10 @@ static int nb8800_open(struct net_device *dev)
> phydev = of_phy_connect(dev, priv->phy_node,
> nb8800_link_reconfigure, 0,
> priv->phy_mode);
> - if (!phydev)
> + if (!phydev) {
> + err = -ENODEV;
> goto err_free_irq;
> + }
>
> nb8800_pause_adv(dev);
>
--
Måns Rullgård
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open()
2016-10-17 15:31 [PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open() Wei Yongjun
2016-10-17 15:35 ` Måns Rullgård
@ 2016-10-17 17:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-10-17 17:12 UTC (permalink / raw)
To: weiyj.lk
Cc: jarod, sf84, peter.chen, mans, tremyfr, arnd, f.fainelli,
weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Mon, 17 Oct 2016 15:31:58 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENODEV from the of_phy_connect() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-17 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 15:31 [PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open() Wei Yongjun
2016-10-17 15:35 ` Måns Rullgård
2016-10-17 17:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).