* [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported
@ 2016-10-18 7:20 Niklas Cassel
2016-10-18 14:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2016-10-18 7:20 UTC (permalink / raw)
To: larper, netdev; +Cc: linux-kernel, Niklas Cassel, Jesper Nilsson
From: Niklas Cassel <niklas.cassel@axis.com>
phy_device->supported is originally set by the PHY driver.
The ethernet driver should filter phy_device->supported to only contain
flags supported by the IP.
The IP supports setting rx and tx flow control independently,
therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared.
If the flags are cleared, pause frames cannot be enabled (even if they
are supported by the PHY).
Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: Jesper Nilsson <jespern@axis.com>
Acked-by: Lars Persson <larper@axis.com>
---
drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
index 0d0053128542..d775729648ef 100644
--- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c
+++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
@@ -982,7 +982,8 @@ static int dwceqos_mii_probe(struct net_device *ndev)
if (netif_msg_probe(lp))
phy_attached_info(phydev);
- phydev->supported &= PHY_GBIT_FEATURES;
+ phydev->supported &= PHY_GBIT_FEATURES | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause;
lp->link = 0;
lp->speed = 0;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported
2016-10-18 7:20 [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported Niklas Cassel
@ 2016-10-18 14:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-10-18 14:29 UTC (permalink / raw)
To: niklas.cassel; +Cc: larper, netdev, linux-kernel, niklass, jespern
From: Niklas Cassel <niklas.cassel@axis.com>
Date: Tue, 18 Oct 2016 09:20:33 +0200
> From: Niklas Cassel <niklas.cassel@axis.com>
>
> phy_device->supported is originally set by the PHY driver.
> The ethernet driver should filter phy_device->supported to only contain
> flags supported by the IP.
> The IP supports setting rx and tx flow control independently,
> therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared.
> If the flags are cleared, pause frames cannot be enabled (even if they
> are supported by the PHY).
>
> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
> Signed-off-by: Jesper Nilsson <jespern@axis.com>
> Acked-by: Lars Persson <larper@axis.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-18 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 7:20 [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported Niklas Cassel
2016-10-18 14:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).