Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Cc: David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Ariel Elior <ariel.elior@qlogic.com>
Subject: Re: [PATCH net-next] bnx2x: ethtool -x full support
Date: Thu, 20 Oct 2016 07:26:27 -0700	[thread overview]
Message-ID: <1476973587.7065.7.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <BL2PR07MB2306E14F54D13CA215D8923C8DD50@BL2PR07MB2306.namprd07.prod.outlook.com>

On Thu, 2016-10-20 at 12:27 +0000, Mintz, Yuval wrote:
> > > From: Eric Dumazet <edumazet@google.com>
> > >
> > > Implement ethtool -x full support, so that rss key can be fetched
> > > instead of assuming it matches /proc/sys/net/core/netdev_rss_key
> > > content.
> > 
> > I'll send a V2, tested with CONFIG_BNX2X_SRIOV=y ;)
> > 
> 
> Hi Eric,
> 
> Thanks for this. Are you planning on sending v2 or do you want us to take over?
> 
> BTW, what's the benefit of changing the RSS keys? Giving the hash properties,
> in which scenarios would we gain by switching keys?

I will send a v2

Changing keys once a day or so might be important for security
purposes. 

I wont give details here ;)

Thanks.

  reply	other threads:[~2016-10-20 14:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 17:08 [PATCH net-next] bnx2x: ethtool -x full support Eric Dumazet
2016-10-18 19:24 ` Eric Dumazet
2016-10-20 12:27   ` Mintz, Yuval
2016-10-20 14:26     ` Eric Dumazet [this message]
2016-12-04 18:15 ` [PATCH v2 " Eric Dumazet
2016-12-05  9:12   ` Mintz, Yuval
2016-12-21 17:48     ` [PATCH v3 net-next] bnx2x: ethtool -x support for rss_key Eric Dumazet
2016-12-25 11:36       ` Mintz, Yuval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476973587.7065.7.camel@edumazet-glaptop3.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=Yuval.Mintz@cavium.com \
    --cc=ariel.elior@qlogic.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox