* [PATCH net] net: fec: Call swap_buffer() prior to IP header alignment
@ 2016-10-21 11:34 Fabio Estevam
2016-10-23 21:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2016-10-21 11:34 UTC (permalink / raw)
To: davem; +Cc: fugang.duan, henri.roosen, eric, kernel, rmk, netdev,
Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
Commit 3ac72b7b63d5 ("net: fec: align IP header in hardware") breaks
networking on mx28.
There is an erratum on mx28 (ENGR121613 - ENET big endian mode
not compatible with ARM little endian) that requires an additional
byte-swap operation to workaround this problem.
So call swap_buffer() prior to performing the IP header alignment
to restore network functionality on mx28.
Fixes: 3ac72b7b63d5 ("net: fec: align IP header in hardware")
Reported-and-tested-by: Henri Roosen <henri.roosen@ginzinger.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/net/ethernet/freescale/fec_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 4ce8179..3c888be 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -1430,14 +1430,14 @@ fec_enet_rx_queue(struct net_device *ndev, int budget, u16 queue_id)
skb_put(skb, pkt_len - 4);
data = skb->data;
+ if (!is_copybreak && need_swap)
+ swap_buffer(data, pkt_len);
+
#if !defined(CONFIG_M5272)
if (fep->quirks & FEC_QUIRK_HAS_RACC)
data = skb_pull_inline(skb, 2);
#endif
- if (!is_copybreak && need_swap)
- swap_buffer(data, pkt_len);
-
/* Extract the enhanced buffer descriptor */
ebdp = NULL;
if (fep->bufdesc_ex)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: fec: Call swap_buffer() prior to IP header alignment
2016-10-21 11:34 [PATCH net] net: fec: Call swap_buffer() prior to IP header alignment Fabio Estevam
@ 2016-10-23 21:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-10-23 21:42 UTC (permalink / raw)
To: festevam
Cc: fugang.duan, henri.roosen, eric, kernel, rmk, netdev,
fabio.estevam
From: Fabio Estevam <festevam@gmail.com>
Date: Fri, 21 Oct 2016 09:34:29 -0200
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 3ac72b7b63d5 ("net: fec: align IP header in hardware") breaks
> networking on mx28.
>
> There is an erratum on mx28 (ENGR121613 - ENET big endian mode
> not compatible with ARM little endian) that requires an additional
> byte-swap operation to workaround this problem.
>
> So call swap_buffer() prior to performing the IP header alignment
> to restore network functionality on mx28.
>
> Fixes: 3ac72b7b63d5 ("net: fec: align IP header in hardware")
> Reported-and-tested-by: Henri Roosen <henri.roosen@ginzinger.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-23 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-21 11:34 [PATCH net] net: fec: Call swap_buffer() prior to IP header alignment Fabio Estevam
2016-10-23 21:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).