* [PATCH -next] amd-xgbe: Fix error return code in xgbe_probe()
@ 2016-10-22 14:35 Wei Yongjun
2016-10-25 11:47 ` Tom Lendacky
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-10-22 14:35 UTC (permalink / raw)
To: Tom Lendacky; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return error code -ENODEV from the DMA is not supported error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-main.c b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
index 667e120..6997f11 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-main.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
@@ -613,6 +613,7 @@ static int xgbe_probe(struct platform_device *pdev)
attr = device_get_dma_attr(dev);
if (attr == DEV_DMA_NOT_SUPPORTED) {
dev_err(dev, "DMA is not supported");
+ ret = -ENODEV;
goto err_io;
}
pdata->coherent = (attr == DEV_DMA_COHERENT);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] amd-xgbe: Fix error return code in xgbe_probe()
2016-10-22 14:35 [PATCH -next] amd-xgbe: Fix error return code in xgbe_probe() Wei Yongjun
@ 2016-10-25 11:47 ` Tom Lendacky
0 siblings, 0 replies; 2+ messages in thread
From: Tom Lendacky @ 2016-10-25 11:47 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Wei Yongjun, netdev
On 10/22/2016 09:35 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENODEV from the DMA is not supported error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/net/ethernet/amd/xgbe/xgbe-main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-main.c b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> index 667e120..6997f11 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> @@ -613,6 +613,7 @@ static int xgbe_probe(struct platform_device *pdev)
> attr = device_get_dma_attr(dev);
> if (attr == DEV_DMA_NOT_SUPPORTED) {
> dev_err(dev, "DMA is not supported");
> + ret = -ENODEV;
> goto err_io;
> }
> pdata->coherent = (attr == DEV_DMA_COHERENT);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-25 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-22 14:35 [PATCH -next] amd-xgbe: Fix error return code in xgbe_probe() Wei Yongjun
2016-10-25 11:47 ` Tom Lendacky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).