From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH net-next] netlink: Add nla_memdup() to wrap kmemdup() use on nlattr Date: Wed, 26 Oct 2016 10:59:36 +0200 Message-ID: <1477472376.4059.23.camel@sipsolutions.net> References: <2d0864c85200f1b42b1ebceee7c2dc60fe29f26a.1477471562.git.tgraf@suug.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thomas Graf , davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org Return-path: In-Reply-To: <2d0864c85200f1b42b1ebceee7c2dc60fe29f26a.1477471562.git.tgraf-G/eBtMaohhA@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org >  /** > + * nla_memdup - duplicate attribute memory (kmemdup) > + * @src: netlink attribute to duplicate from > + * @gfp: GFP mask Actually, is there any point in passing a GFP mask? None of the current users need it, and it seems fairly unlikely to be needed since this is typically used on the netlink input path, where you surely shouldn't need GFP_ATOMIC or so? johannes