Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	Neal Cardwell <ncardwell@google.com>,
	Yuchung Cheng <ycheng@google.com>,
	Soheil Hassas Yeganeh <soheil@google.com>,
	Eric Dumazet <edumazet@google.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH net-next 0/2] tcp: tcp_get_info() locking changes
Date: Fri,  4 Nov 2016 11:54:30 -0700	[thread overview]
Message-ID: <1478285672-3195-1-git-send-email-edumazet@google.com> (raw)

This short series prepares tcp_get_info() for more detailed infos.

In order to not slow down fast path, our goal is to use the normal
socket spinlock instead of custom synchronization.

All we need to ensure is that tcp_get_info() is not called with
ehash lock, which might dead lock, since packet processing would acquire
the spinlocks in reverse way.

Eric Dumazet (2):
  tcp: shortcut listeners in get_tcp_info()
  tcp: no longer hold ehash lock while calling tcp_get_info()

 include/linux/tcp.h  |  2 --
 net/ipv4/inet_diag.c | 48 +++++++++++++++++++++++++++++--------------
 net/ipv4/tcp.c       | 57 ++++++++++++++++++++++++++++------------------------
 net/ipv4/tcp_input.c |  4 ----
 4 files changed, 64 insertions(+), 47 deletions(-)

-- 
2.8.0.rc3.226.g39d4020

             reply	other threads:[~2016-11-04 18:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 18:54 Eric Dumazet [this message]
2016-11-04 18:54 ` [PATCH net-next 1/2] tcp: shortcut listeners in tcp_get_info() Eric Dumazet
2016-11-04 18:54 ` [PATCH net-next 2/2] tcp: no longer hold ehash lock while calling tcp_get_info() Eric Dumazet
2016-11-09 18:03 ` [PATCH net-next 0/2] tcp: tcp_get_info() locking changes David Miller
2016-11-09 18:58   ` Eric Dumazet
2016-11-09 19:24     ` [PATCH net-next] tcp: remove unaligned accesses from tcp_get_info() Eric Dumazet
2016-11-09 19:30       ` Soheil Hassas Yeganeh
2016-11-09 20:46       ` Yuchung Cheng
2016-11-10  3:51       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478285672-3195-1-git-send-email-edumazet@google.com \
    --to=edumazet@google.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=soheil@google.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox