From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 639242063CE for ; Fri, 10 Jan 2025 07:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736493241; cv=none; b=GkBz79zdolDzLPpyitbZIaSIyzX1k9o+gCLr1sNcuXXTFaUBsgPTyAMpNq4+7qm4VBPnKE6YD9Uio8EAgWnB29FXjc43C/f1nOk6uW7Zas/ClYWbAMDJqRMhd0IvVX1LoUOvbBj8dqwl8Et5jTcqXrVXHnwVQhIZj1UdChiQaCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736493241; c=relaxed/simple; bh=lprOQfulzu8v6KvGdaC/bIeIPCWpKvc6opCkgeRU8p8=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=hIEAW8rMWzwBJkf4mhOkKqhw1RiCyaXdrr62ZBzLDq2LTsIyzPGh/ifbze84ucHbhmclrMLTS0JWSXJCVAQdj6b6BJ2Z+r4RViClLH2+e/Q5suKtlmZt+rp60GgnejpPzObbJPx6jNunOCf2fg3U/87OYrqOWOccsiUUIsmy7/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yv/mGnw7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yv/mGnw7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736493238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rQbXIksEk073+Fi/YrEVMIhtLpzXwHk7tiFH7RnZK5M=; b=Yv/mGnw7bFv2bru2WS2HtNI1nJAa23pdy5ABEV+5iGXXokKa18rEjlWazz/Zut4Urvp4tX D0yz9sBOH5JIvidX5dIsi0GJXHvFzfVKS0NoeXX9zfAb4ab3spOIbtBviIbUFcbOUfkh2D gE7seXFrHtFWTKc2k+vl+qASsDsIrjY= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-270-O0KBR35FP7uFyN5xYPBuug-1; Fri, 10 Jan 2025 02:13:56 -0500 X-MC-Unique: O0KBR35FP7uFyN5xYPBuug-1 X-Mimecast-MFC-AGG-ID: O0KBR35FP7uFyN5xYPBuug Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 511911955D64; Fri, 10 Jan 2025 07:13:54 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4C52530001BE; Fri, 10 Jan 2025 07:13:49 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20250110055058.GA63811@sol.localdomain> References: <20250110055058.GA63811@sol.localdomain> <20250110010313.1471063-1-dhowells@redhat.com> <20250110010313.1471063-3-dhowells@redhat.com> To: Eric Biggers Cc: dhowells@redhat.com, Herbert Xu , Chuck Lever , Trond Myklebust , "David S. Miller" , Marc Dionne , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-crypto@vger.kernel.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/8] crypto/krb5: Provide Kerberos 5 crypto through AEAD API Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1478992.1736493228.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 10 Jan 2025 07:13:48 +0000 Message-ID: <1478993.1736493228@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Eric Biggers wrote: > It sounds like a lot of workarounds had to be implemented to fit these > protocols into the crypto_aead API. > = > It also seems unlikely that there will be other implementations of these > protocols added to the kernel, besides the one you're adding in crypto/k= rb5/. > = > Given that, providing this functionality as library functions instead wo= uld be > much simpler. Take a look at how crypto/kdf_sp800108.c works, for examp= le. Yes. That's how I did my first implementation. I basically took the code from net/sunrpc/auth_gss/ and made it more generic. Herbert wants it done this way, however. :-/ David