From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH v3] ip6_output: ensure flow saddr actually belongs to device Date: Mon, 14 Nov 2016 17:44:27 +0100 Message-ID: <1479141867.3723362.787321689.4A3DCFD6@webmail.messagingengine.com> References: <27cccef1-06d9-74b3-5b8a-912850119a76@cumulusnetworks.com> <20161113232813.28926-1-Jason@zx2c4.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Jason A. Donenfeld" , David Ahern , Netdev , WireGuard mailing list , LKML , YOSHIFUJI Hideaki Return-path: In-Reply-To: <20161113232813.28926-1-Jason@zx2c4.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" List-Id: netdev.vger.kernel.org On Mon, Nov 14, 2016, at 00:28, Jason A. Donenfeld wrote: > This puts the IPv6 routing functions in parity with the IPv4 routing > functions. Namely, we now check in v6 that if a flowi6 requests an > saddr, the returned dst actually corresponds to a net device that has > that saddr. This mirrors the v4 logic with __ip_dev_find in > __ip_route_output_key_hash. In the event that the returned dst is not > for a dst with a dev that has the saddr, we return -EINVAL, just like > v4; this makes it easy to use the same error handlers for both cases. > > Signed-off-by: Jason A. Donenfeld > Cc: David Ahern > --- > Changes from v2: > It turns out ipv6_chk_addr already has the device enumeration > logic that we need by simply passing NULL. > > net/ipv6/ip6_output.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c > index 6001e78..b3b5cb6 100644 > --- a/net/ipv6/ip6_output.c > +++ b/net/ipv6/ip6_output.c > @@ -926,6 +926,10 @@ static int ip6_dst_lookup_tail(struct net *net, > const struct sock *sk, > int err; > int flags = 0; > > + if (!ipv6_addr_any(&fl6->saddr) && > + !ipv6_chk_addr(net, &fl6->saddr, NULL, 1)) > + return -EINVAL; Hmm, this check is too permissive, no? E.g. what happens if you move a link local address from one interface to another? In this case this code would still allow the saddr to be used. I just also quickly read up on the history (sorry was travelling last week) and wonder if you ever saw a user space facing bug or if this is basically some difference you saw while writing out of tree code? Thanks, Hannes