From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: [PATCH net-next 4/5] net/mlx4_en: use napi_complete_done() return value Date: Tue, 15 Nov 2016 10:15:14 -0800 Message-ID: <1479233715-9905-5-git-send-email-edumazet@google.com> References: <1479233715-9905-1-git-send-email-edumazet@google.com> Cc: netdev , Willem de Bruijn , Adam Belay , Zach Brown , Tariq Toukan , Yuval Mintz , Ariel Elior , Eric Dumazet , Eric Dumazet To: "David S . Miller" Return-path: Received: from mail-pf0-f178.google.com ([209.85.192.178]:34374 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932110AbcKOSQI (ORCPT ); Tue, 15 Nov 2016 13:16:08 -0500 Received: by mail-pf0-f178.google.com with SMTP id c4so25488996pfb.1 for ; Tue, 15 Nov 2016 10:16:08 -0800 (PST) In-Reply-To: <1479233715-9905-1-git-send-email-edumazet@google.com> Sender: netdev-owner@vger.kernel.org List-ID: Do not rearm interrupts if we are busy polling. mlx4 uses separate CQ for TX and RX, so number of TX interrupts does not change, unfortunately. Signed-off-by: Eric Dumazet Cc: Willem de Bruijn Cc: Adam Belay Cc: Tariq Toukan Cc: Yuval Mintz Cc: Ariel Elior --- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c index 2cc91002064f..22f08f9ef464 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c @@ -1137,8 +1137,8 @@ int mlx4_en_poll_rx_cq(struct napi_struct *napi, int budget) done = 0; } /* Done for now */ - napi_complete_done(napi, done); - mlx4_en_arm_cq(priv, cq); + if (napi_complete_done(napi, done)) + mlx4_en_arm_cq(priv, cq); return done; } -- 2.8.0.rc3.226.g39d4020