netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] netns: fix get_net_ns_by_fd(int pid) typo
@ 2016-11-18  9:41 Stefan Hajnoczi
  2016-11-18 17:40 ` Rami Rosen
  2016-11-18 19:02 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2016-11-18  9:41 UTC (permalink / raw)
  To: netdev; +Cc: David S. Miller, Stefan Hajnoczi

The argument to get_net_ns_by_fd() is a /proc/$PID/ns/net file
descriptor not a pid.  Fix the typo.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/net/net_namespace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
index fc4f757..0940598 100644
--- a/include/net/net_namespace.h
+++ b/include/net/net_namespace.h
@@ -170,7 +170,7 @@ static inline struct net *copy_net_ns(unsigned long flags,
 extern struct list_head net_namespace_list;
 
 struct net *get_net_ns_by_pid(pid_t pid);
-struct net *get_net_ns_by_fd(int pid);
+struct net *get_net_ns_by_fd(int fd);
 
 #ifdef CONFIG_SYSCTL
 void ipx_register_sysctl(void);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] netns: fix get_net_ns_by_fd(int pid) typo
  2016-11-18  9:41 [PATCH] netns: fix get_net_ns_by_fd(int pid) typo Stefan Hajnoczi
@ 2016-11-18 17:40 ` Rami Rosen
  2016-11-18 19:02 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Rami Rosen @ 2016-11-18 17:40 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: Netdev, David S. Miller

On 18 November 2016 at 11:41, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The argument to get_net_ns_by_fd() is a /proc/$PID/ns/net file
> descriptor not a pid.  Fix the typo.
>

Acked-by: Rami Rosen <roszenrami@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] netns: fix get_net_ns_by_fd(int pid) typo
  2016-11-18  9:41 [PATCH] netns: fix get_net_ns_by_fd(int pid) typo Stefan Hajnoczi
  2016-11-18 17:40 ` Rami Rosen
@ 2016-11-18 19:02 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-11-18 19:02 UTC (permalink / raw)
  To: stefanha; +Cc: netdev

From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Fri, 18 Nov 2016 09:41:46 +0000

> The argument to get_net_ns_by_fd() is a /proc/$PID/ns/net file
> descriptor not a pid.  Fix the typo.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-18 19:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-18  9:41 [PATCH] netns: fix get_net_ns_by_fd(int pid) typo Stefan Hajnoczi
2016-11-18 17:40 ` Rami Rosen
2016-11-18 19:02 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).