* [PATCH net-next] tuntap: remove unnecessary sk_receive_queue length check during xmit
@ 2016-11-23 2:26 Jason Wang
2016-11-24 21:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2016-11-23 2:26 UTC (permalink / raw)
To: netdev, linux-kernel; +Cc: mst, Jason Wang
After commit 1576d9860599 ("tun: switch to use skb array for tx"),
sk_receive_queue was not used any more. So remove the uncessary
sk_receive_queue length check during xmit.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/net/tun.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 64e694c..e2af2dd 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -878,13 +878,6 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev)
sk_filter(tfile->socket.sk, skb))
goto drop;
- /* Limit the number of packets queued by dividing txq length with the
- * number of queues.
- */
- if (skb_queue_len(&tfile->socket.sk->sk_receive_queue) * numqueues
- >= dev->tx_queue_len)
- goto drop;
-
if (unlikely(skb_orphan_frags(skb, GFP_ATOMIC)))
goto drop;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] tuntap: remove unnecessary sk_receive_queue length check during xmit
2016-11-23 2:26 [PATCH net-next] tuntap: remove unnecessary sk_receive_queue length check during xmit Jason Wang
@ 2016-11-24 21:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-11-24 21:07 UTC (permalink / raw)
To: jasowang; +Cc: netdev, linux-kernel, mst
From: Jason Wang <jasowang@redhat.com>
Date: Wed, 23 Nov 2016 10:26:49 +0800
> After commit 1576d9860599 ("tun: switch to use skb array for tx"),
> sk_receive_queue was not used any more. So remove the uncessary
> sk_receive_queue length check during xmit.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Good catch, applied, thanks Jason.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-24 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 2:26 [PATCH net-next] tuntap: remove unnecessary sk_receive_queue length check during xmit Jason Wang
2016-11-24 21:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).