netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel@vger.kernel.org
Cc: dave@stgolabs.net, dbueso@suse.de, dvyukov@google.com,
	jasowang@redhat.com, kvm@vger.kernel.org, mark.rutland@arm.com,
	mst@redhat.com, netdev@vger.kernel.org,
	paulmck@linux.vnet.ibm.com,
	virtualization@lists.linux-foundation.org
Subject: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()
Date: Thu, 24 Nov 2016 10:25:11 +0000	[thread overview]
Message-ID: <1479983114-17190-1-git-send-email-mark.rutland@arm.com> (raw)

For several reasons, it would be beneficial to kill off ACCESS_ONCE()
tree-wide, in favour of {READ,WRITE}_ONCE(). These work with aggregate types,
more obviously document their intended behaviour, and are necessary for tools
like KTSAN to work correctly (as otherwise reads and writes cannot be
instrumented separately).

While it's possible to script the bulk of this tree-wide conversion, some cases
such as the virtio code, require some manual intervention. This series moves
the virtio and vringh code over to {READ,WRITE}_ONCE(), in the process fixing a
bug in the virtio headers.

Thanks,
Mark.

Mark Rutland (3):
  tools/virtio: fix READ_ONCE()
  vringh: kill off ACCESS_ONCE()
  tools/virtio: use {READ,WRITE}_ONCE() in uaccess.h

 drivers/vhost/vringh.c        | 5 +++--
 tools/virtio/linux/compiler.h | 2 +-
 tools/virtio/linux/uaccess.h  | 9 +++++----
 3 files changed, 9 insertions(+), 7 deletions(-)

-- 
2.7.4

             reply	other threads:[~2016-11-24 10:25 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24 10:25 Mark Rutland [this message]
2016-11-24 10:25 ` [PATCH 1/3] tools/virtio: fix READ_ONCE() Mark Rutland
2016-11-24 11:34   ` Cornelia Huck
2016-11-25  2:38   ` Jason Wang
2016-11-24 10:25 ` [PATCH 2/3] vringh: kill off ACCESS_ONCE() Mark Rutland
2016-11-24 11:10   ` Christian Borntraeger
2016-11-24 11:35   ` Cornelia Huck
2016-11-25  2:40   ` Jason Wang
2016-11-24 10:25 ` [PATCH 3/3] tools/virtio: use {READ,WRITE}_ONCE() in uaccess.h Mark Rutland
2016-11-24 11:37   ` Cornelia Huck
2016-11-25  2:40   ` Jason Wang
2016-11-24 20:36 ` [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE() Michael S. Tsirkin
2016-11-25 11:22   ` Mark Rutland
2016-11-25 11:33     ` Christian Borntraeger
2016-11-25 12:23       ` Mark Rutland
2016-11-25 12:40         ` Peter Zijlstra
2016-11-25 12:44           ` Peter Zijlstra
2016-11-25 14:56             ` Boqun Feng
2016-11-25 15:21               ` Dmitry Vyukov
2016-11-25 16:10                 ` Mark Rutland
2016-11-25 16:17                   ` Peter Zijlstra
2016-11-25 16:32                     ` Mark Rutland
2016-11-25 16:49                     ` Christian Borntraeger
2016-11-25 17:28                       ` Mark Rutland
2016-11-25 17:42                         ` Peter Zijlstra
2016-11-25 18:46                         ` Christian Borntraeger
2016-11-25 21:08                       ` Michael S. Tsirkin
2016-11-25 21:45                         ` Christian Borntraeger
2016-11-25 17:28                     ` Dmitry Vyukov
2016-11-25 17:43                       ` Mark Rutland
2016-11-25 17:52                       ` Linus Torvalds
2016-11-25 18:07                         ` Mark Rutland
2016-11-25 18:47                           ` Linus Torvalds
2016-11-25 14:35           ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479983114-17190-1-git-send-email-mark.rutland@arm.com \
    --to=mark.rutland@arm.com \
    --cc=dave@stgolabs.net \
    --cc=dbueso@suse.de \
    --cc=dvyukov@google.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).