From: "Andy Johnson" <johnsonzjo@gmail.com>
To: netdev@vger.kernel.org
Subject: Question about arp_error_report() (IPV4): clarification
Date: Sat, 5 Jan 2008 10:43:24 +0200 [thread overview]
Message-ID: <147a89290801050043p24b3a116j75dc58954cdf8ed7@mail.gmail.com> (raw)
Hi,
In neigh_timer_handler( ), (core/neighbour.c), there is a comment which says:
# It is very thin place. report_unreachable is very complicated
# routine. Particularly, it can hit the same neighbour entry!
# So that, we try to be accurate and avoid dead loop. --ANK
I tried to figure exactly what this comment mean (when dealing with IPV4).
Can someone elaborate in 3-4 sentences on it ?
Why "hit the same neighbour entry" can cause any complications ?
Why is report_unreachable() considered complicated ?
It seems to be simple, or am I missing something?
As far as I understand, eventually ipv4_link_failure()
(net/ipv4/route.c) is called when report_unreachable() is invoked.
(The path is: arp_error_report() calls dst_link_failure(skb), which in
case of ipv4, calls ipv4_link_failure().)
So it seems simply a matter of calling eventually ipv4_link_failure(),
which ends up with generating ICMP.
Regards,
Andy
reply other threads:[~2008-01-05 8:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147a89290801050043p24b3a116j75dc58954cdf8ed7@mail.gmail.com \
--to=johnsonzjo@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox