From: "Andy Johnson" <johnsonzjo@gmail.com>
To: netdev@vger.kernel.org
Subject: xfrm_lookup() and XFRM_POLICY_ICMP
Date: Thu, 31 Jan 2008 10:42:08 +0200 [thread overview]
Message-ID: <147a89290801310042y1c3f926flcf7433835d8d9961@mail.gmail.com> (raw)
Hello,
A question about XFRM_POLICY_ICMP:
I had tried to understand this check in __xfrm_lookup() method in
net/xfrm/xfrm_policy.c (the recent 2.6 git dave miller tree):
...
...
if ((flags & XFRM_LOOKUP_ICMP) && !(policy->flags & XFRM_POLICY_ICMP))
goto error;
...
...
Why is the check for XFRM_POLICY_ICMP? I had grepped under the kernel tree,
and the only place where XFRM_POLICY_ICMP appears is here (except its definition
in xfrm.h).
I also grepped under openswan tree, and could not find XFRM_POLICY_ICMP.
(the struct xfrm_userpolicy_info in openswan includes XFRM_POLICY_ALLOW and
XFRM_POLICY_BLOCK and XFRM_POLICY_LOCALOK, but not XFRM_POLICY_ICMP).
I also grepped under iproute2 tree (from git) and there is no XFRM_POLICY_ICMP.
So is this there a way at all to set XFRM_POLICY_ICMP? and if not - maybe this
check is not needed at all ?
Regards,
Andy
reply other threads:[~2008-01-31 8:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147a89290801310042y1c3f926flcf7433835d8d9961@mail.gmail.com \
--to=johnsonzjo@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox