From: Johan Hovold <johan@kernel.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Timur Tabi <timur@codeaurora.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH net v2 2/5] net: bcmgenet: fix phydev reference leak
Date: Thu, 24 Nov 2016 19:21:28 +0100 [thread overview]
Message-ID: <1480011691-13278-3-git-send-email-johan@kernel.org> (raw)
In-Reply-To: <1480011691-13278-1-git-send-email-johan@kernel.org>
Make sure to drop the reference taken by of_phy_find_device() when
initialising MOCA PHYs.
Fixes: 6ac9de5f6563 ("net: bcmgenet: Register link_update callback for
all MoCA PHYs")
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/net/ethernet/broadcom/genet/bcmmii.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
index 457c3bc8cfff..2e745bd51df4 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -542,8 +542,10 @@ static int bcmgenet_mii_of_init(struct bcmgenet_priv *priv)
/* Make sure we initialize MoCA PHYs with a link down */
if (phy_mode == PHY_INTERFACE_MODE_MOCA) {
phydev = of_phy_find_device(dn);
- if (phydev)
+ if (phydev) {
phydev->link = 0;
+ put_device(&phydev->mdio.dev);
+ }
}
return 0;
--
2.7.3
next prev parent reply other threads:[~2016-11-24 18:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 18:21 [PATCH net v2 0/5] net: fix phydev reference leaks Johan Hovold
2016-11-24 18:21 ` [PATCH net v2 1/5] net: dsa: fix fixed-link-phy device leaks Johan Hovold
2016-11-24 18:21 ` Johan Hovold [this message]
2016-11-24 18:21 ` [PATCH net v2 3/5] net: fsl/fman: fix phydev reference leak Johan Hovold
2016-11-24 18:21 ` [PATCH net v2 4/5] net: fsl/fman: fix fixed-link-phydev " Johan Hovold
2016-11-25 10:54 ` Madalin-Cristian Bucur
2016-11-24 18:21 ` [PATCH net v2 5/5] net: qcom/emac: fix of_node and phydev leaks Johan Hovold
2016-11-24 18:55 ` Timur Tabi
2017-01-09 19:49 ` Timur Tabi
2017-01-10 8:43 ` Johan Hovold
2016-11-28 1:02 ` [PATCH net v2 0/5] net: fix phydev reference leaks David Miller
2016-11-28 2:11 ` Timur Tabi
2016-11-28 4:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480011691-13278-3-git-send-email-johan@kernel.org \
--to=johan@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).