From: fgao@ikuai8.com
To: davem@davemloft.net, maheshb@google.com, edumazet@google.com,
netdev@vger.kernel.org, gfree.wind@gmail.com
Cc: Gao Feng <fgao@ikuai8.com>
Subject: [PATCH net-next v2 1/1] driver: ipvlan: Use NF_IP_PRI_LAST as hook priority instead of INT_MAX
Date: Sun, 27 Nov 2016 19:18:02 +0800 [thread overview]
Message-ID: <1480245482-10357-1-git-send-email-fgao@ikuai8.com> (raw)
From: Gao Feng <fgao@ikuai8.com>
It is better to use NF_IP_PRI_LAST instead of INT_MAX as hook priority.
The former is good at readability and easier to maintain.
Signed-off-by: Gao Feng <fgao@ikuai8.com>
---
v2: Add the lost header file. It is added in local but not in v1 patch
v1: Inital patch
drivers/net/ipvlan/ipvlan_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index ab90b22..01c7446 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -7,6 +7,7 @@
*
*/
+#include "linux/netfilter_ipv4.h"
#include "ipvlan.h"
static u32 ipvl_nf_hook_refcnt = 0;
@@ -16,13 +17,13 @@
.hook = ipvlan_nf_input,
.pf = NFPROTO_IPV4,
.hooknum = NF_INET_LOCAL_IN,
- .priority = INT_MAX,
+ .priority = NF_IP_PRI_LAST,
},
{
.hook = ipvlan_nf_input,
.pf = NFPROTO_IPV6,
.hooknum = NF_INET_LOCAL_IN,
- .priority = INT_MAX,
+ .priority = NF_IP_PRI_LAST,
},
};
--
1.9.1
next reply other threads:[~2016-11-27 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 11:18 fgao [this message]
2016-11-28 19:26 ` [PATCH net-next v2 1/1] driver: ipvlan: Use NF_IP_PRI_LAST as hook priority instead of INT_MAX Mahesh Bandewar (महेश बंडेवार)
2016-11-29 1:14 ` Gao Feng
2016-11-29 17:36 ` Mahesh Bandewar (महेश बंडेवार)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480245482-10357-1-git-send-email-fgao@ikuai8.com \
--to=fgao@ikuai8.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gfree.wind@gmail.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox