netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: sfr@canb.auug.org.au, netdev@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org
Cc: Alexander Duyck <alexander.h.duyck@intel.com>, davem@davemloft.net
Subject: Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum
Date: Mon, 28 Nov 2016 14:26:02 -0800	[thread overview]
Message-ID: <1480371962.2402.36.camel@intel.com> (raw)
In-Reply-To: <20161128153927.15466.99193.stgit@ahduyck-blue-test.jf.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

On Mon, 2016-11-28 at 10:42 -0500, Alexander Duyck wrote:
> When I implemented the GSO partial support in the Intel drivers I was
> using
> lco_csum to compute the checksum that we needed to plug into the IPv4
> checksum field in order to cancel out the data that was not a part of the
> IPv4 header.  However this didn't take into account that the transport
> offset might be pointing to the inner transport header.
> 
> Instead of using lco_csum I have just coded around it so that we can use
> the outer IP header plus the IP header length to determine where we need
> to
> start our checksum and then just call csum_partial ourselves.
> 
> This should fix the SIT issue reported on igb interfaces as well as
> simliar
> issues that would pop up on other Intel NICs.
> 
> ---
> 
> Alexander Duyck (2):
>       igb/igbvf: Don't use lco_csum to compute IPv4 checksum
>       ixgbe/ixgbevf: Don't use lco_csum to compute IPv4 checksum

Stephen, I have applied Alex's patches to my net-queue tree.  Can you
confirm they resolve the bug seen?

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-11-28 22:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 15:42 [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum Alexander Duyck
2016-11-28 15:42 ` [net PATCH 1/2] igb/igbvf: " Alexander Duyck
2016-11-28 15:42 ` [net PATCH 2/2] ixgbe/ixgbevf: " Alexander Duyck
2016-11-28 22:26 ` Jeff Kirsher [this message]
2016-11-28 23:43   ` [net PATCH 0/2] " Stephen Rothwell
2016-11-29  9:07     ` Stephen Rothwell
2017-01-11 23:19       ` Stephen Rothwell
2016-11-30 14:47 ` David Miller
2016-11-30 21:15   ` Jeff Kirsher
2016-12-01 20:41     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480371962.2402.36.camel@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).