From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "kubakici@wp.pl" <kubakici@wp.pl>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [PATCH RFC v2] ethtool: implement helper to get flow_type value
Date: Tue, 29 Nov 2016 18:44:16 +0000 [thread overview]
Message-ID: <1480445054.3154.4.camel@intel.com> (raw)
In-Reply-To: <20161129152144.484bea62@jkicinski-Precision-T1700>
On Tue, 2016-11-29 at 15:21 +0000, Jakub Kicinski wrote:
> On Mon, 28 Nov 2016 15:03:43 -0800, Jacob Keller wrote:
> > +static inline __u32 ethtool_get_flow_spec_type(__u32 flow_type)
> > +{
> > + return flow_type & (FLOW_EXT | FLOW_MAC_EXT);
>
> I don't have anything of substance to say but I think you are missing
> a
> negation (~) here compared to the code you are replacing ;)
HAH! Yes you are right. I made a mistake when copying this out of my
driver header file.
Will fix. Sorry for the thrash, and thanks for catching my mistake.
Regards,
Jake
prev parent reply other threads:[~2016-11-29 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 23:03 [PATCH RFC v2] ethtool: implement helper to get flow_type value Jacob Keller
2016-11-29 15:21 ` Jakub Kicinski
2016-11-29 18:44 ` Keller, Jacob E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480445054.3154.4.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).